Review main Merged

81450[TASK] Update ckeditor5 to v40

Andreas Kienast CR +2 V +2 Expert +817 −732 updated 10/19/23, 08:28

Commit message

This commit updates ckeditor5 to v40. See changelog at
https://github.com/ckeditor/ckeditor5/releases/tag/v40.0.0.

Executed commands:

    npm i --save \
        @ckeditor/ckeditor5-alignment@^40.0.0 \
        @ckeditor/ckeditor5-autoformat@^40.0.0 \
        @ckeditor/ckeditor5-basic-styles@^40.0.0 \
        @ckeditor/ckeditor5-block-quote@^40.0.0 \
        @ckeditor/ckeditor5-clipboard@^40.0.0 \
        @ckeditor/ckeditor5-code-block@^40.0.0 \
        @ckeditor/ckeditor5-core@^40.0.0 \
        @ckeditor/ckeditor5-dev-utils@^39.1.0 \
        @ckeditor/ckeditor5-editor-classic@^40.0.0 \
        @ckeditor/ckeditor5-engine@^40.0.0 \
        @ckeditor/ckeditor5-essentials@^40.0.0 \
        @ckeditor/ckeditor5-find-and-replace@^40.0.0 \
        @ckeditor/ckeditor5-heading@^40.0.0 \
        @ckeditor/ckeditor5-horizontal-line@^40.0.0 \
        @ckeditor/ckeditor5-html-support@^40.0.0 \
        @ckeditor/ckeditor5-indent@^40.0.0 \
        @ckeditor/ckeditor5-link@^40.0.0 \
        @ckeditor/ckeditor5-list@^40.0.0 \
        @ckeditor/ckeditor5-paragraph@^40.0.0 \
        @ckeditor/ckeditor5-paste-from-office@^40.0.0 \
        @ckeditor/ckeditor5-remove-format@^40.0.0 \
        @ckeditor/ckeditor5-show-blocks@^40.0.0 \
        @ckeditor/ckeditor5-source-editing@^40.0.0 \
        @ckeditor/ckeditor5-special-characters@^40.0.0 \
        @ckeditor/ckeditor5-style@^40.0.0 \
        @ckeditor/ckeditor5-table@^40.0.0 \
        @ckeditor/ckeditor5-theme-lark@^40.0.0 \
        @ckeditor/ckeditor5-ui@^40.0.0 \
        @ckeditor/ckeditor5-undo@^40.0.0 \
        @ckeditor/ckeditor5-utils@^40.0.0 \
        @ckeditor/ckeditor5-word-count@^40.0.0
    npm run build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 82

Show 62 more files

Review log 79

  1. Andreas Kienast uploaded patch set 1 10/18/23, 14:07

  2. Andreas Kienast updated the commit message in patch set 2 10/18/23, 14:08

  3. core-ci voted on patch set 1 V +1 10/18/23, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47910

  4. core-ci voted on patch set 2 V +1 10/18/23, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47911

  5. Oliver Hader commented on patch set 2 V +1 CR +1 10/18/23, 14:58

    Not sure how to test the breaking changes explicitly...
  6. Andreas Kienast commented on patch set 2 10/19/23, 07:02

    Reply

    AFAICS we're not even affected by the breaking changes as we don't use the affected modules.
  7. Benjamin Franzke commented on patch set 2 V +1 CR +1 10/19/23, 08:17

    package.json:96

    39.2 was release in the meantime, but that isn't relevant right now.
  8. Andreas Kienast voted on patch set 2 V +2 CR +2 10/19/23, 08:19

  9. Andreas Kienast merged patch set 3 10/19/23, 08:28