Review 12.4 Merged

81461[TASK] Improve invalidArguments tests for ImageViewHelper

Nikita Hovratov CR +2 V +2 Easy +26 −12 updated 10/22/23, 09:54

Commit message

- Remove duplicate test case for src="" and image="null"
- Avoid instantiating ImageViewHelper with "new" -> use TemplateView
- Add missing scenarios for possible exceptions

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 10/22/23, 09:44

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48025

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/22/23, 09:54

  4. Nikita Hovratov merged patch set 2 10/22/23, 09:54