Review 12.4 Merged

81463[TASK] Remove dead catch in ImageViewHelper

Nikita Hovratov CR +2 V +2 Easy +0 −6 updated 10/22/23, 15:06

Commit message

RuntimeException is never thrown in the executed code of
ImageViewHelper. Reason is, that the image either is
inside the fallback storage "0" or it was already
caught by InvalidArgumentException catch block.

For reference: There is no way to find out, which
RuntimeException the author meant to catch. I assume it
was the one in AbstractFile->getStorage (code: 1381570091).

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Nikita Hovratov commented on patch set 1 10/22/23, 14:27

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48044

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/22/23, 14:44

  4. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/22/23, 15:06

  5. Nikita Hovratov merged patch set 2 10/22/23, 15:06