81472[TASK] Avoid traverseFlexFormXMLData() in cleanup:flexforms
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Anja Leichsenring +1
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+66 −42
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfComplexDataStructure.xmlnew+61 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfComplexDataStructureValueExpected.xmlnew+72 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfComplexDataStructureValueInput.xmlnew+97 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfSimpleDataStructure.xmlnew+32 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfSimpleDataStructureValueExpected.xmlnew+19 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/cleanFlexFormHandlesValuesOfSimpleDataStructureValueInput.xmlnew+35 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/DataStructureOfSingleSheet.xmlrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/DataStructureWithSheet.xmlrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/FlexFormToolsTest.php+154 −3
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.phpdeleted+0 −75
Review log 1318
-
Christian Kuhn uploaded patch set 1 10/18/23, 16:22
-
Christian Kuhn uploaded patch set 2 10/18/23, 16:27
-
core-ci voted on patch set 2 V -1 10/18/23, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47917
-
core-ci voted on patch set 1 V -1 10/18/23, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47916
-
Christian Kuhn uploaded patch set 3
V -110/19/23, 08:52 -
core-ci voted on patch set 3 V -1 10/19/23, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47930
-
Christian Kuhn uploaded patch set 4
V -110/20/23, 09:22 -
core-ci voted on patch set 4 V +1 10/20/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47962
-
Christian Kuhn uploaded patch set 5
V +110/20/23, 10:09 -
core-ci voted on patch set 5 V +1 10/20/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47963
-
Oliver Klee commented on patch set 5 10/20/23, 10:50
Do the tests make sense without the change as well? If so, maybe we can have them in a pre-patch that we also backport to 12.4 (and maybe also to 11.5). -
Stefan Bürk voted on patch set 5 V +1 CR +1 10/20/23, 10:52
-
Christian Kuhn commented on patch set 5 10/20/23, 10:53
Reply
they don't work directly since the new implementation does better error handling, and details like the _TOGGLE things are not covered by previous implementation. thus: no pre-patch. -
Oliver Klee voted on patch set 5 V +1 10/20/23, 11:00
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/20/23, 11:12
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 10/20/23, 11:18
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/20/23, 11:19
-
Christian Kuhn merged patch set 6 10/20/23, 11:19