Review main Merged

81473[TASK] Show original user on new line in ElementHistoryController

Josef Glatz CR +2 V +2 Easy +2 −2 updated 10/23/23, 09:12

Commit message

This patch improves the readability of the record history view
of an element which was edited in switchTo mode by showing the
original user always on a new line.

div tags are used instead of span tags, to reduce any dependency
on bootstrap classes for displaying an element as display:block.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1216

  1. Josef Glatz uploaded patch set 1 10/19/23, 05:55

  2. core-ci voted on patch set 1 V +1 10/19/23, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47923

  3. Josef Glatz updated the commit message in patch set 2 V +1 10/19/23, 06:10

  4. core-ci voted on patch set 2 V +1 10/19/23, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47924

  5. Josef Glatz commented on patch set 2 10/19/23, 06:18

    This change is ready for review.
    You find before/after screenshots of the patch in the issue description!
  6. Andreas Kienast commented on patch set 2 10/19/23, 09:18

    History.html:65

    What's the benefit of using a utility class over a simple `div`?
  7. Josef Glatz commented on patch set 2 CR -1 10/19/23, 11:42

    History.html:65 Reply

    > What's the benefit of using a utility class over a simple `div`? Will updated as discussed in slack
  8. Josef Glatz uploaded patch set 3 CR -1 V +1 10/19/23, 17:41

  9. Josef Glatz commented on patch set 3 10/19/23, 17:41

    History.html:65 Reply

    Done
  10. Josef Glatz updated the commit message in patch set 4 10/19/23, 17:45

  11. Oliver Klee voted on patch set 4 CR +1 10/19/23, 17:46

  12. core-ci voted on patch set 4 V +1 10/19/23, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47947

  13. core-ci voted on patch set 3 V +1 10/19/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47946

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 10/23/23, 09:11

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 10/23/23, 09:12

  16. Christian Kuhn merged patch set 5 10/23/23, 09:12