81474[BUGFIX] File checks should honor open_basedir setting, IM presets
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 9
- Bug #101778Configuration Presets open_basedir
- Bug #101921open_basedir restriction in effect. File(/typo3/sysext/form/Resources/Public/Css/form.css) is not within the allowed
- Bug #101444Running the setup command returns "not found"
- Bug #70869Install tool/ Configuration presets/ Image handling settings => findGraphicsMagickInPaths fails with openBasedir
- Bug #85174open_basedir prevents executing of cli commands
- Bug #98545file_exists(): open_basedir restriction in effect
- Bug #100021Incorrect path because of absolutely reference file(s) in typo3/cms-dashboard plus it causes open_basedir warnings
- Bug #98330PHP warning log with EXT-syntax using asset vh in BE
- Bug #101350open_basedir restriction in effect
Files 5
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+5 −20
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+2 −2
- typo3/sysext/core/Classes/Utility/PathUtility.php2+72 −0
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+5 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+5 −1
Review log 45
-
Garvin Hicking uploaded patch set 1 10/19/23, 07:45
-
Mathias Brodala commented on patch set 1 CR -1 10/19/23, 07:49
-
core-ci voted on patch set 1 V +1 10/19/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47925
-
Garvin Hicking commented on patch set 1 10/19/23, 11:00
PathUtility.php:460Reply UnresolvedYou're right, yes. I was about to refactor it already, but then I saw that all the other issues referencing open_basedir problems all do their own is_file/file_exists check, so I wasn't sure what the API in the end should be to unify this. I'm afraid this goes very deep into areas I'm not proficient with yet. To fix the most pressing issue of presets not being available, the two 1-liners in ...Preset.php would be sufficient, maybe the scope of this patch should be reduced until then...?! -
Garvin Hicking abandoned the change 06/13/24, 07:09
PathUtility.php:460