Review main Merged

81475[TASK] Update `terser` to 5.22

Andreas Kienast CR +2 V +2 Normal +85 −85 updated 10/19/23, 13:01

Commit message

Executed commands:

    npm install --save-dev terser@^5.22.0
    npm run build

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 810

  1. Andreas Kienast uploaded patch set 1 10/19/23, 07:59

  2. core-ci voted on patch set 1 V +1 10/19/23, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47926

  3. Andreas Kienast uploaded patch set 2 V +1 10/19/23, 08:34

  4. core-ci voted on patch set 2 V +1 10/19/23, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47929

  5. Oliver Klee commented on patch set 2 10/19/23, 09:20

    Any particular reason for this update we could mention in the commit message? A pre-patch to another change, a bugfix we want to have, or just a casual update?
  6. Andreas Kienast commented on patch set 2 10/19/23, 09:22

    Reply

    It's just a casual update. I usually mention this in the commit message, if it's *not* for casual reasons.
  7. Oliver Klee commented on patch set 2 V +1 CR +1 10/19/23, 09:43

    Reply

    Ah, I see. Thanks for the explanation!
  8. Benjamin Franzke voted on patch set 2 V +1 CR +1 10/19/23, 12:20

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 10/19/23, 13:01

  10. Andreas Kienast merged patch set 3 10/19/23, 13:01