Review main Merged

81491[TASK] Proper DI in FlexFormTools

Christian Kuhn CR +2 V +2 Normal +87 −136 updated 10/20/23, 13:37

Commit message

The event dispatcher should always be injected
via DI, either directly or through makeInstance().
It should not be nullable.

Switch a couple of service consumers to get an
instance injected.

Note further patches will remove left over state
properties from FlexFormTools ensuring the service
is fully stateless in the end, which is pretty
much the case already, but not obvious.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9