81493[TASK] Enable keyboard navigation on tabs
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- Build/Sources/TypeScript/backend/form-engine-validation.ts+1 −1
- Build/Sources/TypeScript/backend/tabs.ts+2 −2
- typo3/sysext/backend/Resources/Private/Partials/ModuleTemplate/Tabs.html+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tabs.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+2 −2
Review log 1117
-
Patrick Schriner uploaded patch set 1 10/20/23, 15:00
-
core-ci voted on patch set 1 V -1 10/20/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47978
-
Patrick Schriner uploaded patch set 2
V -110/20/23, 16:44 -
Patrick Schriner uploaded patch set 3 10/20/23, 16:49
-
core-ci voted on patch set 2 V +1 10/20/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47982
-
core-ci voted on patch set 3 V +1 10/20/23, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47983
-
Oliver Klee commented on patch set 3 10/20/23, 17:53
Maybe we can also mention in the commit message which tabs are affected (which would also make testing a bit easier). -
Patrick Schriner updated the commit message in patch set 4
V +110/20/23, 18:02 -
Oliver Klee updated the commit message in patch set 5 10/20/23, 18:03
-
Oliver Klee updated the commit message in patch set 6 10/20/23, 18:03
-
Oliver Klee commented on patch set 6 10/20/23, 18:03
Reply
Done -
Oliver Klee commented on patch set 6 10/20/23, 18:11
I have just tested editing records in the BE with Firefox 118 on Kubuntu. Both with and without this change I was able to switch between the TCEforms tabs using the cursor keys. So I don't quite understand yet what is possible with this change that was not possible before. Am I missing something here? -
core-ci voted on patch set 4 V +1 10/20/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47986
-
Patrick Schriner commented on patch set 6 10/20/23, 18:14
Reply Unresolved
On Chromium (Ubuntu) I'm not able to navigate between tabs without this change. Maybe I'm missing something -
core-ci voted on patch set 5 V +1 10/20/23, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47987
-
core-ci voted on patch set 6 V +1 10/20/23, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47988
-
Patrick Schriner abandoned the change 10/26/23, 11:24
As this seems to be a niche problem