Review main Abandoned

81493[TASK] Enable keyboard navigation on tabs

Patrick Schriner CR 0 V 0 Easy +9 −9 updated 10/26/23, 11:24

Commit message

By replacing the tab links with actual buttons, they become usable by
keyboard; otherwise bootstraps tabs plugin renders them useless.

@see https://getbootstrap.com/docs/5.2/components/navs-tabs/#accessibility

This change affects all form engine tabs, e.g., all TCA-based backend tabs.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 1117

  1. Patrick Schriner uploaded patch set 1 10/20/23, 15:00

  2. core-ci voted on patch set 1 V -1 10/20/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47978

  3. Patrick Schriner uploaded patch set 2 V -1 10/20/23, 16:44

  4. Patrick Schriner uploaded patch set 3 10/20/23, 16:49

  5. core-ci voted on patch set 2 V +1 10/20/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47982

  6. core-ci voted on patch set 3 V +1 10/20/23, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47983

  7. Oliver Klee commented on patch set 3 10/20/23, 17:53

    Maybe we can also mention in the commit message which tabs are affected (which would also make testing a bit easier).
  8. Patrick Schriner updated the commit message in patch set 4 V +1 10/20/23, 18:02

  9. Oliver Klee updated the commit message in patch set 5 10/20/23, 18:03

  10. Oliver Klee updated the commit message in patch set 6 10/20/23, 18:03

  11. Oliver Klee commented on patch set 6 10/20/23, 18:03

    Reply

    Done
  12. Oliver Klee commented on patch set 6 10/20/23, 18:11

    I have just tested editing records in the BE with Firefox 118 on Kubuntu. Both with and without this change I was able to switch between the TCEforms tabs using the cursor keys. So I don't quite understand yet what is possible with this change that was not possible before. Am I missing something here?
  13. core-ci voted on patch set 4 V +1 10/20/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47986

  14. Patrick Schriner commented on patch set 6 10/20/23, 18:14

    Reply Unresolved

    On Chromium (Ubuntu) I'm not able to navigate between tabs without this change. Maybe I'm missing something
  15. core-ci voted on patch set 5 V +1 10/20/23, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47987

  16. core-ci voted on patch set 6 V +1 10/20/23, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47988

  17. Patrick Schriner abandoned the change 10/26/23, 11:24

    As this seems to be a niche problem