Review main Merged

81494[FEATURE] ViewHelper to render srcset attribute

Simon Praetorius CR +2 V +2 Hard +979 −0 updated 03/28/26, 12:59

Commit message

This change introduces a new SrcsetViewHelper, which renders
the HTML "srcset" attribute that is used for responsive images.
As the ViewHelper doesn't render a whole HTML tag, it can be used
in different locations:

* with custom `<img>` tags not using the ImageViewHelper
* with `<source>` tags inside of `<picture>`
* with `<link rel="preload" as="image" imagesrcset="..." />` to preload
  responsive images
* with the existing ImageViewHelper using `srcset="..."`

The change also adds a separate class structures to parse, calculate,
and render srcset attributes, independent of both Fluid and FAL.
This makes these classes quite flexible to be used in other locations
of the core, as well as in 3rd party extensions.

The ViewHelper's API tries to be simple and descriptive, which
is why it only allows FAL objects as input. This makes the underlying
processing much more intuitive to the user, as some of the old
scaling options (such as "c" and "m" modifiers) don't really make
sense with responsive images in mind.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Ayke Halder +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Ayke Halder +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 6598

Show 4773 earlier messages
  1. Simon Praetorius uploaded patch set 1 10/20/23, 15:38

  2. core-ci voted on patch set 1 V -1 10/20/23, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47979

  3. Simon Praetorius uploaded patch set 2 V -1 10/20/23, 15:49

  4. core-ci voted on patch set 2 V +1 10/20/23, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47980

  5. Simon Praetorius uploaded patch set 3 V +1 10/20/23, 16:49

  6. core-ci voted on patch set 3 V -1 10/20/23, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47984

  7. Simon Praetorius uploaded patch set 4 V -1 10/20/23, 17:14

  8. core-ci voted on patch set 4 V +1 10/20/23, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47985

  9. Simon Praetorius uploaded patch set 5 V +1 10/20/23, 18:09

  10. core-ci voted on patch set 5 V -1 10/20/23, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47990

  11. Simon Praetorius uploaded patch set 6 V -1 10/20/23, 18:22

  12. core-ci voted on patch set 6 V +1 10/20/23, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47991

  13. Simon Praetorius uploaded patch set 7 V +1 10/23/23, 16:31

  14. core-ci voted on patch set 7 V -1 10/23/23, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48085

  15. Simon Praetorius uploaded patch set 8 V -1 10/23/23, 16:42

  16. core-ci voted on patch set 8 V +1 10/23/23, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48086

  17. Simon Praetorius updated the commit message in patch set 9 V +1 10/23/23, 16:53

  18. core-ci voted on patch set 9 V +1 10/23/23, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48087

  19. Simon Praetorius uploaded patch set 10 V +1 10/23/23, 19:09

  20. core-ci voted on patch set 10 V -1 10/23/23, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48088

  21. Simon Praetorius uploaded patch set 11 V -1 10/23/23, 19:17

  22. core-ci voted on patch set 11 V +1 10/23/23, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48090

  23. Simon Praetorius marked it ready for review 10/23/23, 19:36

  24. Garvin Hicking commented on patch set 11 10/23/23, 20:02

    Quick glance looks very cool, I think there is definitely a need for this. I think "HtmlUtility" somehow looks a bit misleading with its current scope. I like however that this logic is not part of the ViewHelper itself, so that other ViewHelpers could use it too. Maybe being part of the imageService could be an alternative, but that again would inflate the size of a service that is tried to be reduced in scope. Maybe call call it more strictly by a name like "SrcSetHtmlUtility"... (Will give more feedback when I can test-drive it in my installation, will take me some time though)

    HtmlUtility.php:54

    Is there maybe a more general-use method for this, my gut feeling is there might be other characters as well ("#", "%" for example) and a broader URI encoding would be "safer"?
  25. Simon Praetorius commented on patch set 11 10/23/23, 20:23

    Reply

    I decided against ImageService, because it's part of Extbase. Another possibility could be something like ResponsiveImageUtility, but that would be very/too specific... not sure.

    HtmlUtility.php:54 Reply

    Could be... just for clarification: These two characters collide with the srcset syntax directly, while the ones you mentioned don't.
  26. Garvin Hicking commented on patch set 11 10/24/23, 06:47

    Some more generic remarks, I enjoyed checking the code (couldn't "real-life execute" it yet though) - hope this helps as feedback: * Maybe rename ViewHelper to "SrcSetAttributeViewHelper" to better indicate this "only" deals with an attribute (and not a whole "responsive image block") * There's quite a bit of structure embedded in the usage of Array shapes. Maybe it's an idea to use typed Objects (eventually an Interface, maybe allowing to inject further SrcSetItems by i.e. events and allowing central srcset configuration?) for this, to better indicate the structure, and probably enable a fluid API along the way, i.e.: ``` (new SrcSet()) ->with(...[ new SrcSetItem('image-path', 'descriptor'), new SrcSetItem('image-path', 'descriptor'), new SrcSetItem('image-path', 'descriptor'), ]) ->toAttributeList() ``` (or maybe even a typed SrcSetItemInterface ... $items) This could also improve testability in the end, allow injecting a context request attribute (for adjusting testing, mocking file access). Also it would prevent needing to add array shape type hints at several places (which are yet missing, but I believe effort is being made to add this in all of the core for v13). Also: Great work on providing tests for this from the get go. :)

    Reply

    Understood. I must admit I didn't find a better place other than extbase or core/Classes/Html for this, too. But in this case maybe a "proper" service class would be better, preventing a collection of static methods, and the service could be injected into the ViewHelper via DI then.

    HtmlUtility.php:39

    Minor: The operation is more like just "joining" or "building", so maybe "generateSrcsetAttribute" or "buildSrcAttribute" would be more indicative?

    HtmlUtility.php:54 Reply

    I see - do you know if there is a RFC or so mentioning if other characters would clash? And do you know if the other two mentioned (#, %) would be a problem?

    HtmlUtility.php:111

    Type hint missing

    HtmlUtility.php:139

    Type hints missing

    SrcsetViewHelper.php:72

    I believe "proper" DI now works for ViewHelpers as well, so makeInstance could be avoided here
  27. Simon Praetorius uploaded patch set 12 V +1 10/24/23, 15:43

  28. core-ci voted on patch set 12 V -1 10/24/23, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48134

  29. Simon Praetorius uploaded patch set 13 V -1 10/24/23, 16:02

  30. core-ci voted on patch set 13 V -1 10/24/23, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48135

  31. Simon Praetorius uploaded patch set 14 V -1 10/24/23, 19:30

  32. core-ci voted on patch set 14 V +1 10/24/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48136

  33. Simon Praetorius uploaded patch set 15 V +1 10/24/23, 20:04

  34. core-ci voted on patch set 15 V +1 10/24/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48138

  35. Simon Praetorius commented on patch set 15 10/24/23, 20:14

    HtmlUtility.php:39 Reply

    Is called SrcsetAttribute::generateSrcset() now

    HtmlUtility.php:54 Reply

    https://html.spec.whatwg.org/multipage/images.html#parsing-a-srcset-attribute If we wanted to be really specific, we could add the other ASCII whitespace characters listed here: https://infra.spec.whatwg.org/#ascii-whitespace Parenthesis can be safely ignored, I think, because they are just there for future compatibility.

    HtmlUtility.php:111 Reply

    Done

    HtmlUtility.php:139 Reply

    Done

    SrcsetViewHelper.php:72 Reply

    Done
  36. Garvin Hicking commented on patch set 15 10/25/23, 08:21

    This is a great rework, the structure is much more feasible with the OOP approach (albeit a bit longer to read). Thanks for getting on this so quickly. Current patch works in my installation as advertised. I didn't run the tests myself yet. More specific notes attached to distinct places; generally for me there are these main issues left to address: - Whether to use constructor-based DI - Whether to prevent static usage of createFromDescriptors() if possible, refactor to DI-based service/utility - If an interface shall be created and rework the Abstract/implemented classes based on that I hope we can get this off the ground, I'd love the TYPO3 core to be more able to allow modern responsive image implementations. The current v13 FAL improvements go quite well along with this initiative. Thanks!!

    SrcsetAttribute.php:39

    See mention in viewhelper; if possible try to avoid static method here?

    SrcsetAttribute.php:39

    missing native type hint

    SrcsetAttribute.php:47

    Also here, maybe let SrcAttribute use constructor-based DI to inject the SrcsetCandidate "service" and access it non-statically.

    SrcsetAttribute.php:74

    This is a bit hard to read. From what I gather, you store a temporary variable of the first candidate, and ensure all following candidates are of the same type? If so, maybe this check should better be performed at the stage where you add all candidates? Then you could bail out already when these get added, and not at this later stage. And the code might get easier to read. Ideally, then also prevent `instanceof` in favor of a unique type/constant/enum defined in the candidate classes? Also: The 'adder' could do some more sanitizing, i.e. check if a given density/width candidate already exists, if accidentally doubled? Srcsets tend to get unreadable and many copy+paste operations, so this could slide in, and would be cleanable then. Maybe even silently discarded.

    SrcsetAttribute.php:88

    Nice! :)

    SrcsetCandidate.php:23

    This is not my absolute area of expertise, so I wonder if opting for an interface-based approach would allow for future adoption of similar helpers? And then also name this abstract class "AbstractSrcvSetCandidate", implementing the interface...?

    SrcsetViewHelper.php:32

    Add a note inside the ViewHelper inline docs, that it requires FAL assets to work. Suggestion to also rephrase what it does to the beginning of the sentence: ``` Generates a srcset attribute for <img> or <source> tags based on a list of image assets (FAL-based resource object) and their descriptors (width/height). ```

    SrcsetViewHelper.php:34

    Maybe add a link for an explanation of what srcset does and how to utilize it properly, also to understand when to use density or width descriptors.

    SrcsetViewHelper.php:37

    Maybe add a short sentence like: ``` Responsive image operations are all based on an image's width. There are no "height descriptors", and the "w" operator after the number is the only one there is. ``` (I personally wondered, so maybe others do too :D)

    SrcsetViewHelper.php:56

    This may be clear for people using the viewhelper, but maybe add a very short description what "Density" means below the "Density descriptors" section, like: ``` Density describes, whether and with which dimension an image shall be rendered on higher-pixel-depth devices ("Retina"/"HiDPI"). ```

    SrcsetViewHelper.php:71

    DI of image service also needs some thoughts; generally it should be possible to do it constructor-based, however other core viewHelpers don't do this, so that might be unified in one or the other direction. Since constructord-based DI is preferred, we should check whether that could be adopted here and carried over to the other VHs, depending on the core teams preferences?

    SrcsetViewHelper.php:85

    How about: ``` can enforce conversion from the input image to the format specified with this argument ``` (because I personally always wondered if I needed to specify the INPUT file Extension here)

    SrcsetViewHelper.php:87

    How about: ``` Output generated image files using absolute URLs ```

    SrcsetViewHelper.php:100

    Instead of using `SrcAttribute::createFrom` as a static method, let `SrcAttribute` become DI-provided "service/utility" for cleaner OOP?
  37. Simon Praetorius uploaded patch set 16 V +1 10/25/23, 09:51

  38. core-ci voted on patch set 16 V -1 10/25/23, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48153

  39. Simon Praetorius commented on patch set 16 10/25/23, 10:07

    Reply

    Thank you for your extensive review! I addressed some of the issues. For the remaining issues, I'd like to get feedback from more people.

    SrcsetAttribute.php:39 Reply

    The alternative would be a factory class. From my point of view, this would be overkill for such a small scope, however I'm open to the discussion.

    SrcsetAttribute.php:39 Reply

    Done

    SrcsetAttribute.php:47 Reply

    Resolving this since it's already mentioned above.

    SrcsetAttribute.php:74 Reply

    Great idea. I moved the "class uniformity" logic to the adder. The "check duplicates" functionality needs to remain in the function, because width can change after the candidates were added.

    SrcsetAttribute.php:88 Reply

    :)

    SrcsetCandidate.php:23 Reply

    I think that an Interface would be overkill here, since I don't think that there will be many changes in this area of the HTML spec.

    SrcsetViewHelper.php:32 Reply

    I added some more documentation here. I think, once the whole responsive image area is covered, there needs to be a chapter in the documentation. The VH reference is probably the wrong place to go into the details.

    SrcsetViewHelper.php:34 Reply

    Done

    SrcsetViewHelper.php:37 Reply

    Done

    SrcsetViewHelper.php:56 Reply

    Done

    SrcsetViewHelper.php:71 Reply

    My take: I'm not sure if it's wise to use constructor injection in a class that depends on a class from an external package.

    SrcsetViewHelper.php:85 Reply

    Done

    SrcsetViewHelper.php:87 Reply

    Done

    SrcsetViewHelper.php:100 Reply

    Resolving this since it's already mentioned above.
  40. Simon Praetorius uploaded patch set 17 V -1 10/25/23, 10:09

  41. core-ci voted on patch set 17 V +1 10/25/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48155

  42. Simon Praetorius updated the commit message in patch set 18 V +1 11/08/23, 11:29

  43. core-ci voted on patch set 18 V +1 11/08/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48710

  44. Simon Praetorius uploaded patch set 19 V +1 03/04/24, 13:09

  45. Simon Praetorius commented on patch set 19 03/04/24, 13:12

    All of these aren't mission critical imho.

    SrcsetAttribute.php:39 Reply

    Done

    SrcsetCandidate.php:23 Reply

    Done

    SrcsetViewHelper.php:71 Reply

    Done
  46. core-ci voted on patch set 19 V -1 03/04/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53845

  47. Simon Praetorius uploaded patch set 20 V -1 03/04/24, 13:30

  48. core-ci voted on patch set 20 V -1 03/04/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53846

  49. Simon Praetorius uploaded patch set 21 V -1 03/04/24, 15:00

  50. core-ci voted on patch set 21 V -1 03/04/24, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53866

  51. Simon Praetorius uploaded patch set 22 V -1 03/04/24, 15:39

  52. core-ci voted on patch set 22 V +1 03/04/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53877

  53. Jasmina Ließmann wrote 10/31/24, 09:58

    Removed cc Jasmina Ließmann.
  54. Simon Schaufelberger commented on patch set 22 03/17/26, 20:02

    @simon@praetorius.me I found this really old feature. Would you like to rebase it for v14 or is it not relevant anymore?
  55. Simon Praetorius commented on patch set 22 03/19/26, 17:35

    Reply

    Not sure, last time there didn‘t seem much interest for it.
  56. Simon Schaufelberger uploaded patch set 23 V +1 03/24/26, 22:50

  57. core-ci voted on patch set 23 V -1 03/24/26, 23:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98628

  58. Ayke Halder commented on patch set 23 03/25/26, 11:08

    Reply

    Just wanted to add that this looks really usable! I'd like to see this feature merged. 👍 --- Some additional idea: This might be out of scope for the feature here and get added in a separate patch instead. * Make `density` an additional argument. * JPG `quality` flag should be set based on the `density` - or also be an additional argument. E.g. that is the output I'm actually heading for: ```html <picture> /* Density `2x` - JPG quality `60` */ <source type="image/jpeg" data-srcset="/fileadmin/_processed_/8/f/csm_example_57eeaef19b.jpg 2216w, […] , /fileadmin/_processed_/8/f/csm_example_8aae9975e0.jpg 420w" media="(-webkit-min-device-pixel-ratio: 1.9), (min-resolution: 1.9dppx)"> /* Density `1x` - JPG quality `80` */ <source type="image/jpeg" data-srcset="/fileadmin/_processed_/8/f/csm_example_6ab63423f9.jpg 1108w, […] , /fileadmin/_processed_/8/f/csm_example_5b9c535812.jpg 210w" media="all"> <img data-sizes="auto" class="img-responsive lazyload" srcset="data:image/svg+xml;charset=utf-8,%3Csvg%20xmlns%3D'http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg'%20viewBox%3D'0%200%202048%201159'%2F%3E" /* * Fallback for robots/google: * `srcset` always takes precedence over `src` in modern borwsers * - and thereby `src` is not downloaded at all if `srcset` is provided. */ src="/fileadmin/_processed_/8/f/csm_example_6ab63423f9.jpg" /* e.g. `1024w` */ width="996" height="564" alt=""> </picture> . ```
  59. Ayke Halder commented on patch set 23 03/25/26, 11:25

    SrcsetViewHelper.php:122

    This loop asks the db individually for each candidate. Having many candidates and many pictures on page quickly becomes a lot of queries on the db. Some future improvement should add the option to "pre-warm" running `imageService->applyProcessingInstructions()` in a loop to get already processed images for all the candidates at once. Thereby querying the db only once per image - and not once per candidate.
  60. Helmut Hummel commented on patch set 23 03/25/26, 11:35

    SrcsetViewHelper.php:62

    What I don't like is that multiple inputs can be used to produce the same output. Why not commit to one input possibility only?

    SrcsetViewHelper.php:77

    same here. what is the benefit of it? I only see downsides (inkonsistent usages across extensions or even within extension or projects, multiple code paths that need to be implemented and maintained)
  61. Simon Praetorius commented on patch set 23 03/25/26, 12:44

    SrcsetViewHelper.php:77 Reply

    Ok, then let‘s use csv instead of arrays and with `w` suffix. That way it‘s similar to the HTML standard. I think the original reasoning was to be flexible in Fluid, but since then the `f:join` ViewHelper has been introduced which can be used here.
  62. Ayke Halder commented on patch set 23 03/25/26, 13:03

    SrcsetViewHelper.php:77 Reply

    I'd say use data structs whenever possible -> stay with array. Use `f:split` for CSV to convert to array. ``` {csvConfig -> f:split(separator: ',')} {f:split(value: '1x,2x', separator: ',')} ```
  63. Simon Praetorius uploaded patch set 24 V -1 03/26/26, 12:49

  64. Simon Praetorius commented on patch set 24 03/26/26, 12:53

    Reply

    density feature currently out-of-scope

    SrcsetViewHelper.php:62 Reply

    Done

    SrcsetViewHelper.php:77 Reply

    I've changed the PHP API to only allow arrays as input, while the Fluid ViewHelper sticks with comma-separated values. I think this is a good compromise, as it allows easy input inline in Fluid templates, which is also consistent with how you would do it in plain HTML.
  65. Simon Praetorius commented on patch set 24 03/26/26, 12:57

    Reply

    I'd rather stick to `{f:image.srcset()}` for simplicity. Concerning the object structure, I think this is a bit overkill, when it's "just" about "100w" and "1x".

    HtmlUtility.php:54 Reply

    I don't think this is necessary for the targeted use cases of this API.

    SrcsetViewHelper.php:77 Reply

    Done
  66. core-ci voted on patch set 24 V -1 03/26/26, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98777

  67. Simon Praetorius uploaded patch set 25 V -1 03/26/26, 13:21

  68. Simon Praetorius commented on patch set 25 03/26/26, 13:27

    SrcsetViewHelper.php:122 Reply

    Not sure if this can be accomplished with the current API. If I understand your request correctly, you are talking about checking the DB if a processed file already exists? Feel free to address this in a follow-up. We could do this even after feature-freeze I think.
  69. core-ci voted on patch set 25 V -1 03/26/26, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98781

  70. Simon Praetorius uploaded patch set 26 V -1 03/26/26, 14:26

  71. core-ci voted on patch set 26 V +1 03/26/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98785

  72. Simon Schaufelberger voted on patch set 26 CR +1 V +1 03/26/26, 15:58

  73. Ayke Halder commented on patch set 26 03/26/26, 17:56

    SrcsetViewHelper.php:100

    ```suggestion $cropArea = $this->getCropAreaFromArguments($image, $this->arguments['crop'], $this->arguments['cropVariant']); $cropArea = $cropArea->isEmpty() ? null : $cropArea->makeAbsoluteBasedOnFile($image); ``` Maybe move cropArea creation outside loop.

    SrcsetViewHelper.php:111

    ```suggestion 'crop' => $cropArea, ```
  1. Simon Praetorius uploaded patch set 27 CR +1 V +1 03/27/26, 08:48

  2. Simon Praetorius commented on patch set 27 03/27/26, 08:48

    SrcsetViewHelper.php:100 Reply

    Done

    SrcsetViewHelper.php:111 Reply

    Done
  3. core-ci voted on patch set 27 V +1 03/27/26, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98842

  4. Garvin Hicking uploaded patch set 28 V +1 03/27/26, 13:08

  5. Garvin Hicking voted on patch set 28 CR +1 V +1 03/27/26, 13:09

  6. core-ci voted on patch set 28 V +1 03/27/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98877

  7. Ayke Halder commented on patch set 28 03/27/26, 14:58

    SrcsetCandidate.php:38

    How about accidental uses of `200px, 300px` instead of `200w, 300w` - shall we protect against this? Right now `200px` results in `x` and a match for `DENSITY_UNIT` - with value of `(float)200p`.

    SrcsetViewHelperTest.php:151

    Maybe also test the 'no duplicate srcset entries for same size images' behaviour here. ```suggestion $template = "{f:image.srcset(image: image, srcset: '400w, 999w', crop: {default:{cropArea:{x:0,y:0,width:0.75,height:1}}})}"; ```
  8. Simon Praetorius uploaded patch set 29 CR +1 V +1 03/27/26, 18:33

  9. Simon Praetorius commented on patch set 29 03/27/26, 18:33

    SrcsetCandidate.php:38 Reply

    Done

    SrcsetViewHelperTest.php:151 Reply

    Done
  10. core-ci voted on patch set 29 V -1 03/27/26, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98909

  11. Simon Praetorius uploaded patch set 30 V -1 03/27/26, 18:51

  12. core-ci voted on patch set 30 V -1 03/27/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98911

  13. Simon Praetorius uploaded patch set 31 V -1 03/27/26, 21:16

  14. core-ci voted on patch set 31 V -1 03/27/26, 21:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98926

  15. Simon Praetorius uploaded patch set 32 V -1 03/27/26, 21:28

  16. core-ci voted on patch set 32 V +1 03/27/26, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98927

  17. Garvin Hicking voted on patch set 32 CR +1 V +1 03/27/26, 22:06

  18. Ayke Halder commented on patch set 33 CR +1 V +1 03/28/26, 12:11

    Published edit on patch set 32.
  19. Ayke Halder voted on patch set 33 CR +1 V +1 03/28/26, 12:12

  20. core-ci voted on patch set 33 V +1 03/28/26, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98954

  21. Garvin Hicking voted on patch set 33 CR +1 V +1 03/28/26, 12:30

  22. Simon Praetorius voted on patch set 33 CR +2 V +2 03/28/26, 12:43

  23. Simon Praetorius merged patch set 34 03/28/26, 12:43

  24. Simon Praetorius commented on patch set 34 03/28/26, 12:43

    Thanks, everyone. Especially @simonschaufi+typo3@gmail.com for digging up the old patch!
  25. Simon Schaufelberger commented on patch set 34 03/28/26, 12:59

    Reply

    With pleasure!