Review main Merged

81496[TASK] Avoid traverseFlexFormXMLData() in ReferenceIndex

Christian Kuhn CR +2 V +2 Hard +165 −94 updated 10/22/23, 09:14

Commit message

Similar to the works done for CLI cleanup:flexforms,
ReferenceIndex no longer uses the FlexFormTools
traverser.

The rewritten implementation is a bit lengthy but
will shrink again with further refactorings that are
possible when this patch is merged.

The patch also extends the 'softref' related tests a
bit to check some more field types. The changes in
ext:impexp tests are the result of a slightly
optimized return value handling.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 12

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/21/23, 11:56

  2. core-ci voted on patch set 1 V -1 10/21/23, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48000

  3. Christian Kuhn uploaded patch set 2 V -1 10/21/23, 12:13

  4. core-ci voted on patch set 2 V +1 10/21/23, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48003

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/21/23, 12:53

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/22/23, 08:59

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/22/23, 09:14

  8. Christian Kuhn merged patch set 3 10/22/23, 09:14