Review main Merged

81501[TASK] Simplify query in cleanup:missingrelations

Christian Kuhn CR +2 V +2 Easy +0 −1 updated 10/22/23, 15:10

Commit message

The main worker query of `bin/typo3 cleanup:missingrelations`
includes a "ref_table !== _FILE" where clause. This detail
is obsolete since #87428: sys_refindex does not add such
rows anymore.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 10/22/23, 12:32

  2. Oliver Klee voted on patch set 1 CR +1 10/22/23, 12:37

  3. core-ci voted on patch set 1 V +1 10/22/23, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48037

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/22/23, 13:09

  5. Oliver Klee voted on patch set 1 V +1 10/22/23, 14:21

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/22/23, 15:10

  7. Christian Kuhn commented on patch set 1 V +2 CR +2 10/22/23, 15:10

    I hope its ok to merge here with a missing +1 testing vote: this is 'obvious' to me after analyzing the refenenceIndex code. what could possibly go wrong? ^^
  8. Anja Leichsenring merged patch set 2 10/22/23, 15:10