Review main Merged

81506[TASK] Remove superflous definition for inline field from sys_workspace

Anja Leichsenring CR +2 V +2 Nightmare +1434 −1448 updated 10/23/23, 08:52

Commit message

After only records of table `sys_workspace_stage` can serve as entries
for the `sys_workspace -> custom_stages` field, no dedicated definition
of foreign_table_field is necessary in TCA. Removing it deletes one
field in the database without other side effects.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 721

Show 701 more files

Review log 710

  1. Anja Leichsenring uploaded patch set 1 10/23/23, 04:13

  2. core-ci voted on patch set 1 V -1 10/23/23, 04:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48059

  3. Anja Leichsenring uploaded patch set 2 V -1 10/23/23, 04:54

  4. core-ci voted on patch set 2 V -1 10/23/23, 05:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48060

  5. Anja Leichsenring uploaded patch set 3 V -1 10/23/23, 05:53

  6. core-ci voted on patch set 3 V +1 10/23/23, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48062

  7. Benni Mack commented on patch set 3 V +1 CR +1 10/23/23, 06:25

    Finally, thank you!
  8. Christian Kuhn voted on patch set 3 V +1 CR +1 10/23/23, 08:52

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/23/23, 08:52

  10. Anja Leichsenring merged patch set 4 10/23/23, 08:52