Review main Merged

81509[BUGFIX] Avoid PHP array access error in workspaces

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/23/23, 17:19

Commit message

When a page with a content element that has images
assigned is copied in workspaces, a PHP array access
error is raised since sys_file_reference TCA has
no sortby ctrl.

Add an appropriate null fallback.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/23/23, 12:50

  2. core-ci voted on patch set 1 V +1 10/23/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48082

  3. Oliver Klee voted on patch set 1 V +1 CR +1 10/23/23, 13:16

  4. Benni Mack voted on patch set 1 V +1 CR +1 10/23/23, 15:00

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/23, 17:19

  6. Christian Kuhn merged patch set 2 10/23/23, 17:19