81511[TASK] Update EXT:styleguide monorepo integration
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 24
- Build/composer/composer.dist.json+2 −0
- Build/Sources/Sass/module/_styleguide.scssnew+66 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/Sass/styleguide-frontend.scssnew+68 −0
- Build/Sources/TypeScript/styleguide/filter.tsnew+22 −0
- Build/Sources/TypeScript/styleguide/find-icons.tsnew+78 −0
- Build/Sources/TypeScript/styleguide/processing-indicator.tsnew+58 −0
- Build/Sources/TypeScript/styleguide/render-notifications.tsnew+64 −0
- Build/Gruntfile.js+9 −0
- Build/tsconfig.json+3 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+11 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/UpgradeCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+1 −3
- typo3/sysext/styleguide/Classes/Controller/BackendController.php+0 −17
- typo3/sysext/styleguide/Resources/Public/Css/backend.cssdeleted+0 −53
- typo3/sysext/styleguide/Resources/Public/Css/styleguide-frontend.css+756 −3860
- typo3/sysext/styleguide/Resources/Public/JavaScript/filter.js+1 −19
- typo3/sysext/styleguide/Resources/Public/JavaScript/find-icons.js+1 −38
- typo3/sysext/styleguide/Resources/Public/JavaScript/processing-indicator.js+1 −47
- typo3/sysext/styleguide/Resources/Public/JavaScript/render-notifications.js+1 −55
Review log 3149
Show 1524 earlier messages
-
Jasmina Ließmann uploaded patch set 1 10/23/23, 20:12
-
core-ci voted on patch set 1 V -1 10/23/23, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48092
-
Christian Kuhn commented on patch set 1 CR -2 10/23/23, 20:29
this will not be merged, but is a test to see what needs to be done. please keep for now. -
Christian Kuhn uploaded patch set 2
V -111/01/23, 07:27Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 2 V -1 11/01/23, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48424
-
Christian Kuhn uploaded patch set 3
V -111/01/23, 08:37Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Christian Kuhn uploaded patch set 4 11/01/23, 08:38
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 4 V -1 11/01/23, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48426
-
Christian Kuhn uploaded patch set 5
V -111/01/23, 08:46Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Christian Kuhn uploaded patch set 6 11/01/23, 08:50
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 5 V -1 11/01/23, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48427
-
core-ci voted on patch set 6 V -1 11/01/23, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48428
-
Christian Kuhn uploaded patch set 7
V -111/01/23, 09:02Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 7 V -1 11/01/23, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48429
-
Christian Kuhn uploaded patch set 8
V -111/01/23, 09:26Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 8 V -1 11/01/23, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48432
-
core-ci commented on patch set 8 11/01/23, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48432
-
Andreas Kienast commented on patch set 8 CR -1 11/01/23, 11:22
Working on the JS foo now -
Andreas Kienast uploaded patch set 9
CR -1V -111/01/23, 12:23Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 9 V -1 11/01/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48439
-
Benjamin Franzke commented on patch set 9 11/01/23, 12:40
Gruntfile.js:1Can be renamed to `Gruntfile.cjs` in the styleguide repo, so you don't have to directly remove it during the merge. (the CI test will not complain about them then and grunt still works, as `Gruntfile.cjs` can be used) …so it can be removed later, without failing the tests right now. -
Andreas Kienast commented on patch set 9 11/01/23, 13:51
Reply
Done -
Christian Kuhn commented on patch set 9 CR -2 11/01/23, 18:14
Gruntfile.js:1Replydone in styleguide repo. -
Christian Kuhn uploaded patch set 10
V -111/01/23, 18:21Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
-
core-ci voted on patch set 10 V -1 11/01/23, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48450
-
Christian Kuhn uploaded patch set 11
V -111/01/23, 18:40Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 11 V +1 11/01/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48451
-
Christian Kuhn uploaded patch set 12
V +111/01/23, 19:18Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 12 V -1 11/01/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48453
-
Christian Kuhn uploaded patch set 13
V -111/01/23, 19:40Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Christian Kuhn uploaded patch set 14 11/01/23, 19:44
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 13 V -1 11/01/23, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48455
-
core-ci voted on patch set 14 V -1 11/01/23, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48456
-
Christian Kuhn uploaded patch set 15
V -111/01/23, 20:26Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 15 V +1 11/01/23, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48458
-
Christian Kuhn uploaded patch set 16
V +111/01/23, 21:18Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Christian Kuhn uploaded patch set 17 11/01/23, 21:21
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 16 V +1 11/01/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48463
-
core-ci voted on patch set 17 V +1 11/01/23, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48464
-
Christian Kuhn uploaded patch set 18
V +111/02/23, 13:18Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Christian Kuhn voted on patch set 18 CR 0 11/02/23, 13:18
-
Benjamin Franzke voted on patch set 18 V +1 CR +1 11/02/23, 13:20
-
Oliver Hader voted on patch set 18 CR +1 11/02/23, 13:22
-
Oliver Hader voted on patch set 18 V +1 11/02/23, 13:23
-
Benni Mack voted on patch set 18 V +1 CR +1 11/02/23, 13:26
-
core-ci voted on patch set 18 V +1 11/02/23, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48489
-
Stefan Bürk voted on patch set 18 V +1 CR +1 11/02/23, 13:36
-
Christian Kuhn voted on patch set 18 V +2 CR +2 11/02/23, 13:36
-
Christian Kuhn merged patch set 19 11/02/23, 13:36