Review main Merged

81511[TASK] Update EXT:styleguide monorepo integration

Jasmina Ließmann CR +2 V +2 Nightmare +1150 −4165 updated 11/02/23, 13:36

Commit message

> composer update --lock
> Build/Scripts/runTests.sh -s buildJavascript
> Build/Scripts/runTests.sh -s buildCss

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 24

Review log 3149

Show 1524 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 10/23/23, 20:12

  2. core-ci voted on patch set 1 V -1 10/23/23, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48092

  3. Christian Kuhn commented on patch set 1 CR -2 10/23/23, 20:29

    this will not be merged, but is a test to see what needs to be done. please keep for now.
  4. Christian Kuhn uploaded patch set 2 V -1 11/01/23, 07:27

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  5. core-ci voted on patch set 2 V -1 11/01/23, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48424

  6. Christian Kuhn uploaded patch set 3 V -1 11/01/23, 08:37

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  7. Christian Kuhn uploaded patch set 4 11/01/23, 08:38

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  8. core-ci voted on patch set 4 V -1 11/01/23, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48426

  9. Christian Kuhn uploaded patch set 5 V -1 11/01/23, 08:46

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  10. Christian Kuhn uploaded patch set 6 11/01/23, 08:50

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  11. core-ci voted on patch set 5 V -1 11/01/23, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48427

  12. core-ci voted on patch set 6 V -1 11/01/23, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48428

  13. Christian Kuhn uploaded patch set 7 V -1 11/01/23, 09:02

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  14. core-ci voted on patch set 7 V -1 11/01/23, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48429

  15. Christian Kuhn uploaded patch set 8 V -1 11/01/23, 09:26

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  16. core-ci voted on patch set 8 V -1 11/01/23, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48432

  17. core-ci commented on patch set 8 11/01/23, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48432

  18. Andreas Kienast commented on patch set 8 CR -1 11/01/23, 11:22

    Working on the JS foo now
  19. Andreas Kienast uploaded patch set 9 CR -1 V -1 11/01/23, 12:23

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  20. core-ci voted on patch set 9 V -1 11/01/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48439

  21. Benjamin Franzke commented on patch set 9 11/01/23, 12:40

    Gruntfile.js:1

    Can be renamed to `Gruntfile.cjs` in the styleguide repo, so you don't have to directly remove it during the merge. (the CI test will not complain about them then and grunt still works, as `Gruntfile.cjs` can be used) …so it can be removed later, without failing the tests right now.
  22. Andreas Kienast commented on patch set 9 11/01/23, 13:51

    Reply

    Done
  23. Christian Kuhn commented on patch set 9 CR -2 11/01/23, 18:14

    Gruntfile.js:1 Reply

    done in styleguide repo.
  24. Christian Kuhn uploaded patch set 10 V -1 11/01/23, 18:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  1. core-ci voted on patch set 10 V -1 11/01/23, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48450

  2. Christian Kuhn uploaded patch set 11 V -1 11/01/23, 18:40

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  3. core-ci voted on patch set 11 V +1 11/01/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48451

  4. Christian Kuhn uploaded patch set 12 V +1 11/01/23, 19:18

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  5. core-ci voted on patch set 12 V -1 11/01/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48453

  6. Christian Kuhn uploaded patch set 13 V -1 11/01/23, 19:40

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  7. Christian Kuhn uploaded patch set 14 11/01/23, 19:44

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  8. core-ci voted on patch set 13 V -1 11/01/23, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48455

  9. core-ci voted on patch set 14 V -1 11/01/23, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48456

  10. Christian Kuhn uploaded patch set 15 V -1 11/01/23, 20:26

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  11. core-ci voted on patch set 15 V +1 11/01/23, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48458

  12. Christian Kuhn uploaded patch set 16 V +1 11/01/23, 21:18

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  13. Christian Kuhn uploaded patch set 17 11/01/23, 21:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  14. core-ci voted on patch set 16 V +1 11/01/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48463

  15. core-ci voted on patch set 17 V +1 11/01/23, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48464

  16. Christian Kuhn uploaded patch set 18 V +1 11/02/23, 13:18

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  17. Christian Kuhn voted on patch set 18 CR 0 11/02/23, 13:18

  18. Benjamin Franzke voted on patch set 18 V +1 CR +1 11/02/23, 13:20

  19. Oliver Hader voted on patch set 18 CR +1 11/02/23, 13:22

  20. Oliver Hader voted on patch set 18 V +1 11/02/23, 13:23

  21. Benni Mack voted on patch set 18 V +1 CR +1 11/02/23, 13:26

  22. core-ci voted on patch set 18 V +1 11/02/23, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48489

  23. Stefan Bürk voted on patch set 18 V +1 CR +1 11/02/23, 13:36

  24. Christian Kuhn voted on patch set 18 V +2 CR +2 11/02/23, 13:36

  25. Christian Kuhn merged patch set 19 11/02/23, 13:36