Review main Merged

81533[BUGFIX] Remove test operating on outdated example

Anja Leichsenring CR +2 V +2 Normal +64 −120 updated 11/19/23, 13:10

Commit message

The test showcased an outdated concept of custom eval implementation.
The showcase has been removed to promote more modern approaches, now
the test fails and is removed, too.

This reveals a cross dependency between acceptance tests, which is
fixed along the way by combining two test files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1522

  1. Anja Leichsenring uploaded patch set 1 10/24/23, 04:13

  2. core-ci voted on patch set 1 V +1 10/24/23, 04:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48108

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/24/23, 07:12

  4. core-ci voted on patch set 1 V -1 10/24/23, 07:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48115

  5. Simon Schaufelberger commented on patch set 1 CR -1 10/24/23, 07:22

    implementation
  6. Nikita Hovratov voted on patch set 1 V 0 CR 0 10/24/23, 07:23

  7. Simon Schaufelberger commented on patch set 1 10/24/23, 07:23

    only main?
  8. Andreas Kienast updated the commit message in patch set 2 CR -1 V -1 10/24/23, 07:45

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 10/24/23, 07:46

  10. Andreas Kienast commented on patch set 2 10/24/23, 07:47

    Reply

    Done

    Reply

    Yes, only main AC tests fail.
  11. core-ci voted on patch set 2 V +1 10/24/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48116

  12. Christian Kuhn voted on patch set 2 V +1 CR +1 10/24/23, 08:01

  13. core-ci voted on patch set 1 V -1 10/24/23, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48115

  14. core-ci voted on patch set 1 V -1 10/24/23, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48115

  15. Christian Kuhn uploaded patch set 3 CR +1 V +1 10/24/23, 09:20

  16. core-ci voted on patch set 3 V +1 10/24/23, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48119

  17. core-ci commented on patch set 3 10/24/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48120

  18. Stefan Bürk voted on patch set 3 V +1 CR +1 10/24/23, 09:52

  19. Christian Kuhn voted on patch set 3 V +1 CR +1 10/24/23, 09:52

  20. Christian Kuhn voted on patch set 3 V +2 CR +2 10/24/23, 09:53

  21. Christian Kuhn merged patch set 4 10/24/23, 09:54

  22. Christian Kuhn commented on patch set 4 11/19/23, 13:10

    looks as if we need this in v12 as well.