Review main Merged

81543[TASK] Clean up class ReferenceIndex

Christian Kuhn CR +2 V +2 Expert +730 −856 updated 10/25/23, 17:11

Commit message

A rewrite of the internal handling:

* The class is now practically a stateless service,
  the two left over properties are 'stable' until
  TCA changes within an instance usage, which is not
  the case in current usages.
* Extraction of setReferenceValue() and it's detail
  methods to CLI command 'cleanup:missingrelations'.
  That command needs an overhaul with another patch,
  but it's not more broken than before.
* Public methods at the start of the file.
* Clean method signature types.
* Disentanglement of code details, removing various
  detail methods to simplify reading. A method with
  eleven arguments has been inlined.
* Happy phpstan along the way.

The entire thing should be much easier to grasp and
follow now. Note getRelations() still returns a rather
opaque array of weird entries which can't be resolved
without additionally touching MissingRelationsCommand
and ext:impexp. This should be streamlined with
further patches.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4