Review main Merged

81545[BUGFIX] Mark erroneous fields within `.formengine-field-item`

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 10/25/23, 17:06

Commit message

FormEngine UI has a rather inconsistent markup. Fields within
Flexforms may appear within another `div` container, causing issues
when trying to mark an erroneous field as such. To solve this
short-termed, additional CSS rules are added to cover such cases.

In the long run, the FormEngine markup must get consolidated.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Thomas Hohn +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 10/25/23, 12:57

  2. core-ci voted on patch set 1 V +1 10/25/23, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48162

  3. Thomas Hohn voted on patch set 1 CR +1 10/25/23, 13:15

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 10/25/23, 16:09

  5. Christian Kuhn commented on patch set 1 10/25/23, 16:09

    tested in main, not tested in v12, though.
  6. Jasmina Ließmann voted on patch set 1 V +2 CR +2 10/25/23, 17:06

  7. Jasmina Ließmann merged patch set 2 10/25/23, 17:06