Review main Merged

81546[TASK] Remove unreachable code in impexp

Christian Kuhn CR +2 V +2 Hard +14 −241 updated 10/25/23, 14:11

Commit message

ReferenceIndex no longer returns arrays having
'type=file' set for a relation type, nor arrays
having 'file' set for 'flexFormRels' since the
removal of internal_type=file with #87428.

Only softref parsers can still return 'file' type
soft references.

The patch removes obsolete code from ext:impexp.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 812

  1. Christian Kuhn uploaded patch set 1 10/25/23, 13:36

  2. Christian Kuhn updated the commit message in patch set 2 10/25/23, 13:43

  3. core-ci voted on patch set 1 V +1 10/25/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48164

  4. Christian Kuhn updated the commit message in patch set 3 10/25/23, 13:44

  5. Christian Kuhn uploaded patch set 4 10/25/23, 13:46

  6. core-ci voted on patch set 3 V +1 10/25/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48167

  7. Benni Mack voted on patch set 4 V +1 CR +1 10/25/23, 14:00

  8. core-ci voted on patch set 2 V +1 10/25/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48166

  9. core-ci voted on patch set 4 V +1 10/25/23, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48169

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/25/23, 14:07

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 10/25/23, 14:10

  12. Christian Kuhn merged patch set 5 10/25/23, 14:11