81547[FEATURE] Events to modify asset data in AssetRenderer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 13
- typo3/sysext/core/Classes/Page/Event/ModifyJavaScriptAssetBeforeRenderingEvent.phpnew+71 −0
- typo3/sysext/core/Classes/Page/Event/ModifyStyleSheetAssetBeforeRenderingEvent.phpnew+71 −0
- typo3/sysext/core/Classes/Page/EventListener/VersionNumberedFilenameEventListener.phpnew+52 −0
- typo3/sysext/core/Classes/Page/AssetRenderer.php9+21 −14
- typo3/sysext/core/Classes/Page/PageRenderer.php1+4 −4
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-102255-AddEventsToModifyAssetURIsInAssetCollector.rst2new+88 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_asset_event/Classes/EventListener/TestEventListener.phpnew+48 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_asset_event/Configuration/Services.yamlnew+9 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_asset_event/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_asset_event/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Page/AssetRendererExtensionTest.phpnew+84 −0
- typo3/sysext/core/Tests/Functional/Page/AssetRendererTest.php+74 −5
- composer.json+1 −0
Review log 3454
Show 1629 earlier messages
-
Simon Praetorius uploaded patch set 1 10/25/23, 13:41
-
core-ci voted on patch set 1 V -1 10/25/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48165
-
Simon Praetorius uploaded patch set 2
V -110/25/23, 14:04 -
core-ci voted on patch set 2 V -1 10/25/23, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48170
-
Simon Praetorius uploaded patch set 3
V -110/25/23, 16:18 -
core-ci voted on patch set 3 V -1 10/25/23, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48185
-
Simon Praetorius uploaded patch set 4
V -110/25/23, 17:26 -
Simon Praetorius uploaded patch set 5 10/25/23, 17:27
-
core-ci voted on patch set 4 V -1 10/25/23, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48192
-
core-ci voted on patch set 5 V -1 10/25/23, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48193
-
Simon Praetorius uploaded patch set 6
V -111/21/23, 18:56 -
core-ci voted on patch set 6 V -1 11/21/23, 19:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49289
-
Simon Praetorius abandoned the change 02/01/24, 09:27
I discussed with benni that there should be a different approach here: Unify PageRenderer and AssetCollector, add Event chain to modify URIs -
Simon Praetorius restored the change 09/06/24, 14:22
-
Simon Praetorius uploaded patch set 7
V -109/06/24, 14:24 -
core-ci voted on patch set 7 V -1 09/06/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64973
-
Simon Praetorius uploaded patch set 8
V -109/06/24, 14:40 -
core-ci voted on patch set 8 V -1 09/06/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64977
-
Simon Praetorius uploaded patch set 9
V -109/06/24, 15:37 -
core-ci voted on patch set 9 V -1 09/06/24, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64987
-
Simon Praetorius uploaded patch set 10
V -109/06/24, 17:04 -
core-ci voted on patch set 10 V -1 09/06/24, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64993
-
Simon Praetorius uploaded patch set 11
V -109/06/24, 17:12 -
core-ci voted on patch set 11 V +1 09/06/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64994
-
Simon Praetorius uploaded patch set 12
V +109/07/24, 15:45 -
core-ci voted on patch set 12 V -1 09/07/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65019
-
Simon Praetorius marked it ready for review 09/07/24, 16:35
-
Simon Praetorius uploaded patch set 13
V -109/07/24, 16:36 -
core-ci voted on patch set 13 V -1 09/07/24, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65023
-
Simon Praetorius uploaded patch set 14
V -109/07/24, 16:44 -
core-ci voted on patch set 14 V +1 09/07/24, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65024
-
Stefan Bürk commented on patch set 14 CR -1 09/07/24, 19:57
Unresolved
We need to discuss some things regarding the events, and Benni asked to postpone this until monday/thusday - thus -1 temp for now. -
Garvin Hicking commented on patch set 14 09/07/24, 20:01
I really like the idea of being able to adjust this with events, as frontend build integration gets more versatile (and complex). Not voting yet because of the implementation details of abstract events and/or pcppAssetRenderer.php:71how about allowing the event to also suppress an asset?AssetRenderer.php:99Same here - also allow to suppress? And/or also allow to change the "rel" attribute? -
Garvin Hicking commented on patch set 14 09/07/24, 21:37
Feature-102255-AddEventsToModifyAssetURIsInAssetCollector.rst:15one '\' missing after 'Event' -
Simon Praetorius uploaded patch set 15
CR -1V +109/09/24, 09:20 -
core-ci voted on patch set 15 V +1 09/09/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65069
-
Simon Praetorius uploaded patch set 16
V +109/09/24, 09:58 -
Simon Praetorius commented on patch set 16 09/09/24, 09:59
I've removed the abstract event and switched to CPP in the events.Feature-102255-AddEventsToModifyAssetURIsInAssetCollector.rst:15ReplyDone -
core-ci voted on patch set 16 V +1 09/09/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65077
-
Garvin Hicking commented on patch set 16 09/09/24, 10:21
ModifyJavaScriptUriEvent.php:29`readonly` for the latter two? -
Simon Praetorius uploaded patch set 17
V +109/09/24, 10:38 -
Simon Praetorius uploaded patch set 18 09/09/24, 10:39
-
Simon Praetorius commented on patch set 18 09/09/24, 10:40
ModifyJavaScriptUriEvent.php:29ReplyDone -
core-ci voted on patch set 17 V +1 09/09/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65083
-
core-ci voted on patch set 18 V +1 09/09/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65084
-
Benni Mack commented on patch set 18 09/11/24, 12:08
AssetRenderer.php:73In addition, I think it would be quite helpful to also modify other attributes with this change, or what do you think? Same in the next one... -
Benni Mack commented on patch set 18 09/11/24, 12:11
AssetRenderer.php:62let's extend this patch a bit further, but rendering the JavaScript AND actually handing this to the Event, should be important to add the PSR-7 request object -
Simon Praetorius uploaded patch set 19
V +109/11/24, 19:48 -
Simon Praetorius uploaded patch set 20 09/11/24, 19:50
-
Simon Praetorius commented on patch set 19 09/11/24, 19:53
AssetRenderer.php:62ReplyDoneAssetRenderer.php:71ReplyDo you have an idea for the api? Maybe set the attributes to null? Or empty array? Or something completely different?AssetRenderer.php:73ReplyDoneAssetRenderer.php:99ReplyDonePageRenderer.php:1293UnresolvedI tried to go up the chain to provide the request in a "proper" way here. However I'm not sure about this `updateState()` construct of `PageRenderer`. Currently, the request doesn't seem to be available here. -
core-ci voted on patch set 20 V +1 09/11/24, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65487
-
core-ci voted on patch set 19 V -1 09/11/24, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65486
-
Garvin Hicking commented on patch set 20 09/11/24, 20:08
AssetRenderer.php:71Reply UnresolvedI'd say that if get(Script|Link)TagAttributes() returns either an empty array or null, then the whole asset would be skipped? -
Simon Praetorius abandoned the change 09/11/24, 21:14