Review 12.4 Abandoned

81549[TASK] Apply CKEditor5 migration during element render

Benjamin Franzke CR 0 V 0 Normal +44 −111 updated 05/04/26, 13:25

Commit message

The migration has previously been performed in EXT:core
as a post-step of the configuration-loader.
This migration is now moved into EXT:rte_ckeditor in
order to allow migration rules for `extraPlugins`
that are derived from `externalPlugins` during element
render – this also allowed to apply migration to
event-modified settings.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 711

  1. Benjamin Franzke uploaded patch set 1 10/25/23, 14:28

  2. core-ci voted on patch set 1 V -1 10/25/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48174

  3. Benjamin Franzke uploaded patch set 2 V -1 11/04/23, 14:32

  4. Benjamin Franzke marked it ready for review 11/04/23, 14:32

  5. core-ci voted on patch set 2 V -1 11/04/23, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48580

  6. Benjamin Franzke uploaded patch set 3 V -1 11/04/23, 15:20

  7. core-ci voted on patch set 3 V -1 11/04/23, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48583

  8. Benjamin Franzke uploaded patch set 4 V -1 12/12/23, 08:53

  9. core-ci voted on patch set 4 V +1 12/12/23, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50579

  10. Oliver Hader updated the commit message in patch set 5 V +1 10/18/24, 14:07

  11. Benni Mack abandoned the change 05/04/26, 13:25

    support for 12.4 version in the free version has been dropped. abandoning this so no one accidentally merges this one (cherry pick is still valid)