Review main Merged

81551[BUGFIX] Add `#[Controller]` attribute to `SuggestWizardController`

Andreas Kienast CR +2 V +2 Easy +2 −0 updated 10/25/23, 15:57

Commit message

The `SuggestWizardController` makes use of constructor DI. However,
necessary configuration was missing, breaking the controller.

This patch adds the necessary `#[Controller]` attribute, preparing
the controller for the dependency container.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Francois Suter +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Francois Suter +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Andreas Kienast uploaded patch set 1 10/25/23, 15:16

  2. Andreas Kienast commented on patch set 1 10/25/23, 15:16

  3. Andreas Kienast updated the commit message in patch set 2 10/25/23, 15:19

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 10/25/23, 15:24

  5. core-ci voted on patch set 1 V +1 10/25/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48179

  6. core-ci voted on patch set 2 V +1 10/25/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48180

  7. Francois Suter voted on patch set 2 V +1 CR +1 10/25/23, 15:42

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 10/25/23, 15:47

  9. Andreas Kienast merged patch set 3 10/25/23, 15:47

  10. Christian Kuhn commented on patch set 3 10/25/23, 15:57

    sorry. this was a regression from https://review.typo3.org/c/Packages/TYPO3.CMS/+/81491 in main.