Review 12.4 Merged

81574[BUGFIX] Replace CSP mutation mode extend by inherit & append

Oliver Hader CR +2 V +2 Normal +167 −57 updated 10/26/23, 08:29

Commit message

MutationMode::Extend has some ambiguity when being invoked
multiple times on modified ancestor source collections.
This change introduces the new MutationMode::InheritOnce,
MutationMode::InheritAgain and MutationMode::Append.

The implicit behavior of MutationMode::Extend changes from the
combination of MutationMode::InheritAgain + MutationMode::Append
to MutationMode::InheritOnce + MutationMode::Append to avoid
side effects with more configurations modifying the policy.

Static mutations loaded from ContentSecurityPolicies.php are
ordered accordoring to the packages dependency hierarchy. That
is the reason, the configuration from ext:core had to be moved
to both ext:backend and ext:frontend.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Oliver Hader uploaded patch set 1 10/26/23, 08:10

  2. core-ci voted on patch set 1 V +1 10/26/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48211

  3. Oliver Hader voted on patch set 1 V +2 CR +2 10/26/23, 08:28

  4. Oliver Hader merged patch set 2 10/26/23, 08:29