81578[BUGFIX] Reset UriBuilder for links generated by PasswordRecoveryService
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2428
Show 3 earlier messages
-
core-ci voted on patch set 1 V -1 10/26/23, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48233
-
Oliver Klee voted on patch set 1 V 0 CR 0 10/26/23, 12:37
-
Garvin Hicking commented on patch set 1 10/26/23, 13:19
Hm, I'm not sure what/why the errors happen in the Unit tests not resolving "some uri". Help appreciated.... -
Oliver Hader commented on patch set 1 10/26/23, 14:59
RecoveryService.php:90`$uriBuilder->setRequest()` seems to be missing here... -
Oliver Hader voted on patch set 1 V +1 CR +1 10/26/23, 14:59
-
Oliver Hader voted on patch set 1 V -1 CR -1 10/26/23, 14:59
-
Oliver Hader voted on patch set 1 V 0 CR 0 10/26/23, 14:59
-
Oliver Hader commented on patch set 1 10/26/23, 15:09
RecoveryService.php:90ReplyWrong. The request is not purged in the `reset()` method. Seems the test mocking is wrong then... I'll check... -
Oliver Hader uploaded patch set 2
CR +1V -110/26/23, 15:20 -
Garvin Hicking commented on patch set 2 10/26/23, 15:26
RecoveryService.php:90ReplyCool thanks for checking... request was specifically mentioned to not be resetted, yes, I checked that too 😵💫 -
core-ci voted on patch set 2 V -1 10/26/23, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48241
-
Oliver Hader commented on patch set 2 V +1 CR +1 10/26/23, 15:30
The patch is fine... Side note: The recovery link in the test mail did not contain a host name (since my site config just uses `base: '/'`). This behavior did exist before this patch already and is a general issue to be tackled.RecoveryService.php:90ReplyDone -
Oliver Hader commented on patch set 2 10/26/23, 15:33
In general the `UriBuilder` should not have a global state. Thus, there might be a "UriBuilderFactory` (or just `UriBuilder::create()`) to retrieve a stateless fresh instance of the `UriBuilder` - similar to `ConnectionPool` and fetching a new `QueryBuilder` for database ops... -
Oliver Hader uploaded patch set 3
CR +1V +110/26/23, 15:35 -
Oliver Hader voted on patch set 3 V +1 CR +1 10/26/23, 15:35
-
Thomas Hohn commented on patch set 3 V +1 CR +1 10/26/23, 15:38
Reply
Done -
core-ci voted on patch set 3 V +1 10/26/23, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48245
-
Christian Kuhn voted on patch set 3 CR +1 10/26/23, 15:46
-
Christian Kuhn commented on patch set 3 10/26/23, 16:42
mmmh. v12 applies, v11 is fiddly. @garvin, could you have a look if v11 is manageable and maybe push a backport if so? -
Stefan Bürk updated the commit message in patch set 4
CR +1V +110/26/23, 21:06 -
Stefan Bürk voted on patch set 4 V +1 CR +1 10/26/23, 21:07
-
core-ci voted on patch set 4 V +1 10/26/23, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48262
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/26/23, 22:48
-
Christian Kuhn merged patch set 5 10/26/23, 22:48
-
Oliver Hader voted on patch set 5 V +1 CR +1 10/27/23, 10:48