Review main Merged

81583[BUGFIX] Allow to configure automatic language detection in form editor

Nikita Hovratov CR +2 V +2 Easy +29 −3 updated 03/28/25, 10:05

Commit message

The security patch #93581 changed the only selectable value for
`translation.language` from an empty string to `default`. However,
`default` does not mean "default behavior" but the default localisation
language, which is always english. Due to this it was impossible to use
the automatic language detection. Forms were always sent with english
translation (if it exists).

To fix this and to make it clearer to the user, a new option "Auto" is
added to the select list inside the form editor and FlexForm overrides.

In addition, "Default" is renamed to "EN" in FlexForm overrides for
clarity and to align with the form editor.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 2333

Show 48 earlier messages
  1. Nikita Hovratov uploaded patch set 1 10/26/23, 15:33

  2. core-ci voted on patch set 1 V +1 10/26/23, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48243

  3. Nikita Hovratov rebased onto patch set 2 V +1 10/27/23, 16:31

  4. core-ci voted on patch set 2 V +1 10/27/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48303

  5. Nikita Hovratov rebased onto patch set 3 V +1 11/03/23, 08:10

  6. core-ci voted on patch set 3 V +1 11/03/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48531

  7. Nikita Hovratov rebased onto patch set 4 V +1 11/16/23, 09:44

  8. core-ci voted on patch set 4 V +1 11/16/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49008

  1. Nikita Hovratov rebased onto patch set 5 V +1 12/07/23, 08:21

  2. core-ci voted on patch set 5 V +1 12/07/23, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50437

  3. Simon Schaufelberger voted on patch set 5 CR +1 12/16/23, 21:17

  4. Guido Schmechel commented on patch set 5 CR +1 V +1 01/27/24, 22:01

    Checked whether the changes are set in the YAML. It still needs to be clarified whether the patch is important enough for 11.
  5. Nikita Hovratov uploaded patch set 6 CR +1 V +1 01/27/24, 23:37

  6. Nikita Hovratov commented on patch set 6 01/27/24, 23:39

    Reply

    Yeah, let's remove v11. People probably have fixed it themselves by now for this version.
  7. core-ci voted on patch set 6 V +1 01/27/24, 23:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52335

  8. Guido Schmechel voted on patch set 6 CR +1 V +1 01/28/24, 10:21

  9. Nikita Hovratov commented on patch set 6 02/18/24, 15:59

    bump.
  10. Simon Schaufelberger voted on patch set 6 CR +1 05/16/24, 09:12

  11. Benni Mack updated the commit message in patch set 7 CR +1 V +1 10/18/24, 13:30

  12. core-ci voted on patch set 7 V -1 10/18/24, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67977

  13. Benni Mack rebased onto patch set 8 V -1 10/26/24, 13:09

  14. core-ci voted on patch set 8 V +1 10/26/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68671

  15. Simon Schaufelberger voted on patch set 8 CR +1 10/26/24, 19:11

  16. Nikita Hovratov uploaded patch set 9 CR +1 V +1 12/05/24, 19:34

  17. core-ci voted on patch set 9 V +1 12/05/24, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70667

  18. Benni Mack voted on patch set 9 CR +1 12/16/24, 14:08

  19. Benni Mack wrote 03/28/25, 09:16

    Topic set to form
  20. Benni Mack voted on patch set 9 V +1 03/28/25, 09:50

  21. Georg Ringer commented on patch set 10 CR +1 V +1 03/28/25, 09:52

    Published edit on patch set 9.
  22. Georg Ringer voted on patch set 10 CR +1 V +1 03/28/25, 09:53

  23. Benni Mack voted on patch set 10 CR +2 V +2 03/28/25, 09:55

  24. core-ci voted on patch set 10 V +1 03/28/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76564

  25. Benni Mack merged patch set 11 03/28/25, 10:05