Review 11.5 Merged

81589[BUGFIX] Reset UriBuilder for links generated by PasswordRecoveryService

Garvin Hicking CR +2 V +2 Easy +4 −1 updated 10/26/23, 22:48

Commit message

The `EXT:felogin/Classes/Service/RecoveryService.php` makes use of
the local $uriBuilder instance building links, however it does
not `reset()` it's state before building a URL.

It seems this only creates an issue when used in conjunction with
`EXT:vhs` (possibly due to adapted fluid/object caching behavior?).

Fixing this by resetting the instance as recommended via
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/UriBuilder.html
should take care of this, even though uriBuilder should be a
singleton only operating within the scope of a single
ActionController.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Garvin Hicking uploaded patch set 1 10/26/23, 19:58

  2. Christian Kuhn commented on patch set 1 10/26/23, 20:00

    thanks for pushing the tricky v11 backport already, garvin!
  3. core-ci voted on patch set 1 V +1 10/26/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48258

  4. Oliver Klee voted on patch set 1 CR +1 10/26/23, 20:44

  5. Oliver Klee voted on patch set 1 V +1 10/26/23, 20:44

  6. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 10/26/23, 21:02

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 10/26/23, 21:07

  8. core-ci voted on patch set 2 V +1 10/26/23, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48261

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 10/26/23, 22:48

  10. Christian Kuhn merged patch set 3 10/26/23, 22:48