Review main Merged

81590[TASK] Avoid calling migrateFlexFormTcaRecursive() twice

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 10/27/23, 09:39

Commit message

With #99756, migrating DS in FlexForms has (indirectly)
been added to parseDataStructureByIdentifier(), so any
DS is "clean" afterwards. FormEngine related ajax
controllers trigger this when a data structure
identifier is supplied.

Calling this a second time in FormEngine TcaFlexPrepare
does not make sense and is removed now.

This allows us to protect that internal method.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2