Review 12.4 Merged

81592[TASK] Escape dynamic values in DOM selectors

Benjamin Franzke CR +2 V +2 Hard +209 −108 updated 11/05/24, 14:36

Commit message

Use a string literal to automatically apply escaping
to variables via selector``. The is essentially
a formatted string with integrated escaping.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 55

Show 35 more files

Review log 45

  1. Benjamin Franzke uploaded patch set 1 10/27/23, 09:01

  2. core-ci voted on patch set 1 V +1 10/27/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48279

  3. Benjamin Franzke commented on patch set 1 V +2 CR +2 10/30/23, 16:25

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 10/30/23, 16:25

  5. Andreas Kienast commented on patch set 2 11/05/24, 14:36

    form-engine-review.ts:142 Unresolved

    Regression, closing `"` is missing. Drive-by fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/86886