81592[TASK] Escape dynamic values in DOM selectors
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 55
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+10 −9
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+3 −2
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+10 −9
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+7 −6
- Build/Sources/TypeScript/backend/form-engine/element/abstract-sortable-select-items.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine/element/category-element.ts+3 −2
- Build/Sources/TypeScript/backend/form-engine/element/color-element.ts+6 −1
- Build/Sources/TypeScript/backend/form-engine/element/folder-element.ts+6 −1
- Build/Sources/TypeScript/backend/form-engine/element/link-element.ts+7 −1
- Build/Sources/TypeScript/backend/form-engine/element/mfa-info-element.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine/element/password-element.ts+10 −3
- Build/Sources/TypeScript/backend/form-engine/element/select-single-element.ts+4 −3
- Build/Sources/TypeScript/backend/viewport/navigation-container.ts+2 −1
- Build/Sources/TypeScript/backend/context-menu.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-review.ts1+2 −1
- Build/Sources/TypeScript/backend/form-engine-suggest.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-validation.ts+11 −9
- Build/Sources/TypeScript/backend/form-engine.ts+19 −17
- Build/Sources/TypeScript/backend/grid-editor.ts+2 −1
- Build/Sources/TypeScript/backend/module-menu.ts+3 −2
Show 35 more files
- Build/Sources/TypeScript/backend/multi-record-selection.ts+3 −2
- Build/Sources/TypeScript/backend/recordlist.ts+3 −2
- Build/Sources/TypeScript/core/tests/literals-test.tsnew+24 −0
- Build/Sources/TypeScript/core/literals.tsnew+17 −0
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+3 −2
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+2 −1
- Build/Sources/TypeScript/install/installer.ts+3 −2
- Build/Sources/TypeScript/workspaces/backend.ts+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/abstract-sortable-select-items.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/category-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/color-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/folder-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/link-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/mfa-info-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/password-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-single-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/navigation-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-suggest.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/grid-editor.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-record-selection.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/literals.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 45
-
Benjamin Franzke uploaded patch set 1 10/27/23, 09:01
-
core-ci voted on patch set 1 V +1 10/27/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48279
-
Benjamin Franzke commented on patch set 1 V +2 CR +2 10/30/23, 16:25
This change is ready for review. -
Benjamin Franzke merged patch set 2 10/30/23, 16:25
-
Andreas Kienast commented on patch set 2 11/05/24, 14:36
form-engine-review.ts:142UnresolvedRegression, closing `"` is missing. Drive-by fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/86886