81593[BUGFIX] Use original file for ProcessedFile::getMimeType and ::getSize
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Garvin Hicking +1
- Guido Schmechel +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1923
-
Christian Weiske uploaded patch set 1 10/27/23, 09:19
-
core-ci voted on patch set 1 V -1 10/27/23, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48280
-
Christian Weiske uploaded patch set 2
V -110/27/23, 09:39 -
Benni Mack commented on patch set 2 10/27/23, 09:45
Hey Christian, should go in v12 as well, right? -
core-ci voted on patch set 2 V +1 10/27/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48281
-
Christian Weiske updated the commit message in patch set 3
V +110/27/23, 09:49 -
Benni Mack voted on patch set 3 CR +1 10/27/23, 09:52
-
Benni Mack voted on patch set 3 V +1 10/27/23, 09:52
-
core-ci voted on patch set 3 V +1 10/27/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48282
-
Oliver Klee voted on patch set 3 CR +1 10/27/23, 10:57
-
Garvin Hicking commented on patch set 3 11/01/23, 09:09
ProcessedFile.php:499Does the method above not throw a similar exception? Don't have the chance to look it up right now. Also, do any unit/functional tests maybe need adoption to also test these two "new" accessors? -
Christian Weiske uploaded patch set 4
CR +1V +111/01/23, 09:35 -
Christian Weiske commented on patch set 4 11/01/23, 09:38
ProcessedFile.php:499ReplyThe RuntimeException comes from getStorage(), so yes getMimeType also needs it. I've added it. Sorry, I have no idea about the tests. -
core-ci voted on patch set 4 V +1 11/01/23, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48434
-
Oliver Klee voted on patch set 4 CR +1 11/01/23, 10:12
-
Benjamin Franzke commented on patch set 4 11/01/23, 11:53
I think `ProcessedFile` needs to be changed to rather return a proper storage from `$this->getStorage()` depending on the result of `usesOriginalFile()`, as basically all cases where `getStorage()` is used are possibly flawed. I do understand however, if we'd rather leave that for a main-only TASK. -
Christian Weiske commented on patch set 4 11/02/23, 11:58
Reply
Just having getStorage() return the original file storage will not work, because `AbstractFile` getter methods also use `$this->properties` and other local properties that would also need to be proxied. Getting all of those correct will be tricky. -
Christian Weiske commented on patch set 4 11/07/23, 09:13
Reply
Done -
Benni Mack commented on patch set 4 CR +1 01/23/24, 22:19
I think the fix is OK for the time being -
Guido Schmechel voted on patch set 4 CR +1 01/27/24, 21:51
-
Garvin Hicking voted on patch set 4 CR +1 V +1 03/11/24, 18:43
-
Georg Ringer voted on patch set 4 CR +2 V +2 03/11/24, 20:49
-
Georg Ringer merged patch set 5 03/11/24, 20:49