Review 12.4 Merged

81594[BUGFIX] Remove array reset due to broken backwards compatibility

Daniel Dorndorf CR +2 V +2 Easy +8 −8 updated 03/06/24, 20:18

Commit message

The reset breaks the mapping if a file upload should be mapped as a
property of an object.

Additionally, parts of the ext:form fix introduced with #100362
have been removed again, since uploadedFiles are now available
in arguments again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Ehret +1
    • Torben Hansen +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Ehret +1
    • Torben Hansen +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2730

Show 45 earlier messages
  1. Daniel Dorndorf uploaded patch set 1 10/27/23, 10:36

  2. core-ci voted on patch set 1 V -1 10/27/23, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48284

  3. Stefan Froemken uploaded patch set 2 V -1 01/17/24, 14:51

  4. Stefan Bürk commented on patch set 2 CR -2 01/17/24, 16:34

    This is not the first patch try to do the same thing. Still, getting there is a issue but this destros the b/c which has been tried. In one of the other patches it's already commented that this needs to be fixed in the extbase database mapper instead. If I remember right, Torben Hansen wanted to look into that too. And it seems that the pushes leads to pipeline stucks for what ever reasons, for example: https://git.typo3.org/typo3/CI/cms/-/pipelines/51693
  5. Stefan Bürk commented on patch set 2 01/17/24, 16:35

    Reply

    Note: going to cancel the stuck pipelines now.
  1. Torben Hansen commented on patch set 2 01/19/24, 18:21

    I tested this patch and it fixes the problem with the TypeConverter uploads. The `reset($fileParameters)` is definitly wrong in our current codebase, since this should only be executed in backend context (extbase module) as far as I can see from the original code in v11. EXT:form fixed this problem with this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78336 - this can however not be easily be applied to custom extensions using own TypeConvertes, since it must be ensured, that uploaded files get merged into extbase parameters. Can we try to re-run CI for this patch?
  2. Tobias Liebig commented on patch set 2 CR +1 V +1 02/14/24, 13:40

    I also tested this patch in my current project and can confirm it fixes the issue.
  3. Alexander Opitz voted on patch set 2 CR +1 V +1 03/01/24, 10:15

  4. Benni Mack commented on patch set 2 03/01/24, 15:48

    I think we could then rework the Form Framework "hack" as seen here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78336
  5. Torben Hansen uploaded patch set 3 CR +1 V +1 03/05/24, 15:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Torben Hansen rebased onto patch set 4 03/05/24, 15:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  7. Stefan Bürk voted on patch set 4 CR 0 03/05/24, 15:54

  8. core-ci voted on patch set 4 V +1 03/05/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53964

  9. Torben Hansen commented on patch set 4 03/05/24, 16:07

    Reply

    Rebase solved the problem
  10. Torben Hansen voted on patch set 4 CR +1 V +1 03/05/24, 16:07

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 03/05/24, 16:14

  12. Tobias Liebig voted on patch set 4 CR +1 V +1 03/05/24, 16:39

  13. Benni Mack commented on patch set 4 CR -2 03/05/24, 16:57

    please remove the hack from EXT:form then
  14. Torben Hansen uploaded patch set 5 CR +1 V +1 03/05/24, 18:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. Torben Hansen commented on patch set 5 03/05/24, 18:29

    Reply

    Done and checked, that file upload in ext:form works
  16. core-ci voted on patch set 5 V +1 03/05/24, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53978

  17. Christian Kuhn voted on patch set 5 CR +1 V +1 03/05/24, 21:45

  18. Benni Mack voted on patch set 5 CR 0 03/05/24, 21:46

  19. Garvin Hicking voted on patch set 5 CR +1 V +1 03/05/24, 21:48

  20. Torben Hansen voted on patch set 5 CR +1 V +1 03/06/24, 07:53

  21. Stefan Bürk voted on patch set 5 CR -1 03/06/24, 09:19

  22. Stefan Bürk voted on patch set 5 CR +2 V +2 03/06/24, 09:34

  23. Stefan Bürk merged patch set 6 03/06/24, 09:34

  24. Christian Ehret commented on patch set 6 03/06/24, 20:15

    I also tested this patch in my current project and can confirm it fixes the issue.
  25. Christian Ehret voted on patch set 6 CR +1 V +1 03/06/24, 20:18