Review main Merged

81596[TASK] Extract "Remaining characters" into Lit element

Andreas Kienast CR +2 V +2 Normal +146 −72 updated 11/06/23, 05:35

Commit message

The FormEngine feature that shows the amount of remaining characters
that fit in a field has been extracted from the
`@typo3/backend/form-engine` god module into a separate Lit element.

Also, the `badge-*` classes are migrated to `text-*` to have a lot less
"bulky" UI.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2333

Show 58 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/27/23, 13:19

  2. core-ci voted on patch set 1 V -1 10/27/23, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48290

  3. Andreas Kienast uploaded patch set 2 V -1 10/27/23, 13:58

  4. core-ci voted on patch set 2 V +1 10/27/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48295

  5. Oliver Hader commented on patch set 2 10/30/23, 07:38

    form-engine.ts:563

    Just a naming thing - maybe use `target` or `element` instead of property `field`
  6. Andreas Kienast commented on patch set 2 10/30/23, 07:48

    form-engine.ts:563 Reply

    Ack
  7. Andreas Kienast uploaded patch set 3 V +1 10/30/23, 07:51

  8. core-ci voted on patch set 3 V +1 10/30/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48343

  1. Andreas Kienast uploaded patch set 4 V +1 10/31/23, 05:48

  2. core-ci voted on patch set 4 V +1 10/31/23, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48377

  3. Andreas Kienast uploaded patch set 5 V +1 11/02/23, 08:22

  4. core-ci voted on patch set 5 V -1 11/02/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48474

  5. Andreas Kienast uploaded patch set 6 V -1 11/02/23, 08:38

  6. core-ci voted on patch set 6 V +1 11/02/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48475

  7. Oliver Hader voted on patch set 6 CR +1 11/02/23, 16:18

  8. Oliver Hader uploaded patch set 7 CR +1 V +1 11/02/23, 17:28

  9. Oliver Hader commented on patch set 7 V +1 CR +1 11/02/23, 17:28

    The previous patch-set was using `text-*` instead of `badge-*` classes
  10. core-ci voted on patch set 7 V +1 11/02/23, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48511

  11. Andreas Kienast commented on patch set 7 11/03/23, 07:45

    Reply

    `text-*` was on purpose, badge looks rather bulky. But that's fine, I could've written this in the commit message 😄.
  12. Andreas Kienast uploaded patch set 8 CR +1 V +1 11/03/23, 08:01

  13. core-ci voted on patch set 8 V +1 11/03/23, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48529

  14. Nikita Hovratov commented on patch set 8 11/03/23, 12:21

    Do you plan to refactor "minimum characters left" as well?
  15. Andreas Kienast commented on patch set 8 11/03/23, 12:30

    Reply

    Yes, but in a separate patch.
  16. Benjamin Franzke commented on patch set 8 CR -1 11/03/23, 12:34

    char-counter.ts:21

    hmpf, I don't like that this is a reference to "another" HTMLElement, which means this object would never be usable with pure-HTML DOM composition (target could never be passed as an HTML attribute), but relies on the fact that target property is set by some other code – and works only if that is done prior to attaching it do the DOM. Without that I had a look into the implementation, it would be nicer to rely on a) the light dom (e.g. make it a wrapper element) or b) pass a reference.
  17. Oliver Hader commented on patch set 8 11/03/23, 12:43

    char-counter.ts:21 Reply

    I had similar thought, but would have been fine with assigning the property during runtime. I guess "pass a reference" is "using a CSS selector" (which probably would be a unique ID)? In case it would be changed in this patch, I'd be in favor of making the new element a wrapping component.
  18. Andreas Kienast uploaded patch set 9 CR -1 V +1 11/03/23, 13:13

  19. core-ci voted on patch set 9 V +1 11/03/23, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48548

  20. Benjamin Franzke uploaded patch set 10 V +1 11/03/23, 13:50

  21. Benjamin Franzke commented on patch set 10 V +1 CR +1 11/03/23, 13:51

    char-counter.ts:21 Reply

    There is unfortunately too much it-might-break fear when wrapping, so we fixed this to be a string based reference for now, where the events are attached/updated via lit lifecycle methods.
  22. core-ci voted on patch set 10 V +1 11/03/23, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48549

  23. Nikita Hovratov voted on patch set 10 V +1 CR +1 11/05/23, 17:14

  24. Benjamin Franzke voted on patch set 10 V +2 CR +2 11/06/23, 05:35

  25. Benjamin Franzke merged patch set 11 11/06/23, 05:35