81596[TASK] Extract "Remaining characters" into Lit element
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/element/typo3-backend-formengine-char-counter.scssnew+6 −0
- Build/Sources/Sass/typo3/_main_form.scss+0 −16
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/form-engine/element/extra/char-counter.ts3new+112 −0
- Build/Sources/TypeScript/backend/form-engine.ts2+8 −52
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −3
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/extra/char-counter.jsnew+17 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
Review log 2333
Show 58 earlier messages
-
Andreas Kienast uploaded patch set 1 10/27/23, 13:19
-
core-ci voted on patch set 1 V -1 10/27/23, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48290
-
Andreas Kienast uploaded patch set 2
V -110/27/23, 13:58 -
core-ci voted on patch set 2 V +1 10/27/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48295
-
Oliver Hader commented on patch set 2 10/30/23, 07:38
-
Andreas Kienast commented on patch set 2 10/30/23, 07:48
form-engine.ts:563ReplyAck -
Andreas Kienast uploaded patch set 3
V +110/30/23, 07:51 -
core-ci voted on patch set 3 V +1 10/30/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48343
-
Andreas Kienast uploaded patch set 4
V +110/31/23, 05:48 -
core-ci voted on patch set 4 V +1 10/31/23, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48377
-
Andreas Kienast uploaded patch set 5
V +111/02/23, 08:22 -
core-ci voted on patch set 5 V -1 11/02/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48474
-
Andreas Kienast uploaded patch set 6
V -111/02/23, 08:38 -
core-ci voted on patch set 6 V +1 11/02/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48475
-
Oliver Hader voted on patch set 6 CR +1 11/02/23, 16:18
-
Oliver Hader uploaded patch set 7
CR +1V +111/02/23, 17:28 -
Oliver Hader commented on patch set 7 V +1 CR +1 11/02/23, 17:28
The previous patch-set was using `text-*` instead of `badge-*` classes -
core-ci voted on patch set 7 V +1 11/02/23, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48511
-
Andreas Kienast commented on patch set 7 11/03/23, 07:45
Reply
`text-*` was on purpose, badge looks rather bulky. But that's fine, I could've written this in the commit message 😄. -
Andreas Kienast uploaded patch set 8
CR +1V +111/03/23, 08:01 -
core-ci voted on patch set 8 V +1 11/03/23, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48529
-
Nikita Hovratov commented on patch set 8 11/03/23, 12:21
Do you plan to refactor "minimum characters left" as well? -
Andreas Kienast commented on patch set 8 11/03/23, 12:30
Reply
Yes, but in a separate patch. -
Benjamin Franzke commented on patch set 8 CR -1 11/03/23, 12:34
char-counter.ts:21hmpf, I don't like that this is a reference to "another" HTMLElement, which means this object would never be usable with pure-HTML DOM composition (target could never be passed as an HTML attribute), but relies on the fact that target property is set by some other code – and works only if that is done prior to attaching it do the DOM. Without that I had a look into the implementation, it would be nicer to rely on a) the light dom (e.g. make it a wrapper element) or b) pass a reference. -
Oliver Hader commented on patch set 8 11/03/23, 12:43
char-counter.ts:21ReplyI had similar thought, but would have been fine with assigning the property during runtime. I guess "pass a reference" is "using a CSS selector" (which probably would be a unique ID)? In case it would be changed in this patch, I'd be in favor of making the new element a wrapping component. -
Andreas Kienast uploaded patch set 9
CR -1V +111/03/23, 13:13 -
core-ci voted on patch set 9 V +1 11/03/23, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48548
-
Benjamin Franzke uploaded patch set 10
V +111/03/23, 13:50 -
Benjamin Franzke commented on patch set 10 V +1 CR +1 11/03/23, 13:51
char-counter.ts:21ReplyThere is unfortunately too much it-might-break fear when wrapping, so we fixed this to be a string based reference for now, where the events are attached/updated via lit lifecycle methods. -
core-ci voted on patch set 10 V +1 11/03/23, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48549
-
Nikita Hovratov voted on patch set 10 V +1 CR +1 11/05/23, 17:14
-
Benjamin Franzke voted on patch set 10 V +2 CR +2 11/06/23, 05:35
-
Benjamin Franzke merged patch set 11 11/06/23, 05:35
form-engine.ts:563