Review main Merged

81598[TASK] Migrate icon-element to @lit/task

Benjamin Franzke CR +2 V +2 Hard +350 −113 updated 11/04/23, 10:44

Commit message

@lit/task graduated from a 2-year @lit-labs phase, to an officially
supported helper library for lit elements. We want to start using it
as it embraces a tri-state model for async operations:

  * pending
  * complete
  * error

…which is important in order to always handle error cases instead of
silently ignoring them. Also existing or currently running requests are
aborted and/or ignored when a newer state has already been activated.

The icon-library deduplication caching strategy is refactored into a
reusable helper instance that is a bit more generic and allows to
abort (ref counted across duplicate requests) async operations.

Commands executed:

  npm install --save @lit/task
  npm run build

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16