Review 12.4 Abandoned

81599[TASK] Catch exception and return new instance of ContentObjectRenderer

TYPO3com CR 0 V 0 Easy +7 −3 updated 10/31/24, 14:48

Commit message

If there was no "currentContentObject" set in the request, the new
instance of ContentObjectRenderer was never reached and lead to an
exception

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 58

  1. TYPO3com uploaded patch set 1 10/27/23, 14:51

  2. core-ci voted on patch set 1 V -1 10/27/23, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48298

  3. Stefan Bürk wrote 10/27/23, 18:48

    Change destination moved from 12.4 to main
  4. Stefan Bürk wrote 10/27/23, 18:50

    Change destination moved from main to 12.4
  5. Stefan Bürk updated the commit message in patch set 2 V -1 10/27/23, 18:50

  6. core-ci voted on patch set 2 V -1 10/27/23, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48313

  7. Stefan Bürk commented on patch set 2 CR -2 10/28/23, 12:14

    Unresolved

    Mhh - `NoSuchArgumentException` is through when an "Extbase Attribute" is requestes which does not exists. However, requesting an attribute on the request object, even if it is a "Extbase Request" dispatches it to the PSR-7 event. Without further information I would say, that a overriden "Extbase Request" from old times by custom or 3rd party extension is passed in, not reflect the changes done for TYPO3 v12 on the extbase request stuff. Therefore, this is an issue of the not aligned xclassed/extended extbase request. That should properly avoid the extbase attribute retrival with getAttribute() and adopt the getExtbaseAttribute() instead. This is comapt code, and hiding the issue of 3rd party code not aligned to TYPO3 v12 code is the charge of the code extending it. I do not see the core in charge to add a additional try {} here not possible with pure core usage. The extending extension need to fix this, not the core.
  8. Benni Mack abandoned the change 10/31/24, 14:48

    Closing this one due to lack of feedback here.