81600[TASK] Extract TCA loading to a factory
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Torben Hansen +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Torben Hansen +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 16
- Build/phpstan/phpstan-baseline.neon+1 −1
- typo3/sysext/core/Classes/Command/CacheWarmupCommand.php+10 −14
- typo3/sysext/core/Classes/Configuration/Event/AfterTcaCompilationEvent.php1+2 −4
- typo3/sysext/core/Classes/Configuration/Event/BeforeTcaOverridesEvent.php1+2 −4
- typo3/sysext/core/Classes/Configuration/Tca/TcaFactory.php7new+197 −0
- typo3/sysext/core/Classes/Core/Event/WarmupBaseTcaCache.phpdeleted+0 −43
- typo3/sysext/core/Classes/Core/BootService.php+13 −4
- typo3/sysext/core/Classes/Core/Bootstrap.php+4 −18
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+0 −162
- typo3/sysext/core/Configuration/Services.yaml+2 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102067-BeforeTcaOverridesEvent.rst1+4 −0
- typo3/sysext/core/Tests/Unit/Utility/AccessibleProxies/ExtensionManagementUtilityAccessibleProxy.php+0 −14
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php1+0 −106
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+3 −1
- typo3/sysext/install/Classes/Service/LateBootService.php+2 −2
- typo3/sysext/install/Classes/Service/LoadTcaService.php+9 −61
Review log 1726
Show 1 earlier messages
-
Christian Kuhn uploaded patch set 1 10/27/23, 15:58
-
Christian Kuhn uploaded patch set 2 10/27/23, 16:02
-
core-ci voted on patch set 1 V +1 10/27/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48299
-
core-ci voted on patch set 2 V +1 10/27/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48300
-
Christian Kuhn uploaded patch set 3
V +110/27/23, 16:14 -
core-ci voted on patch set 3 V +1 10/27/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48302
-
Christian Kuhn uploaded patch set 4
V +110/27/23, 18:34 -
core-ci voted on patch set 4 V +1 10/27/23, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48311
-
Benjamin Franzke uploaded patch set 5
V +111/01/23, 09:34 -
core-ci voted on patch set 5 V +1 11/01/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48433
-
Benjamin Franzke uploaded patch set 6
V +111/01/23, 09:49 -
core-ci voted on patch set 6 V +1 11/01/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48435
-
Benjamin Franzke rebased onto patch set 7
V +111/22/23, 20:53 -
core-ci voted on patch set 7 V +1 11/22/23, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49549
-
Christian Kuhn uploaded patch set 8
V +111/22/23, 21:12 -
core-ci voted on patch set 8 V -1 11/22/23, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49555
-
Christian Kuhn uploaded patch set 9
V -111/22/23, 21:28 -
core-ci voted on patch set 9 V +1 11/22/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49559
-
Torben Hansen commented on patch set 9 11/23/23, 07:45
-
Christian Kuhn commented on patch set 9 11/23/23, 08:40
TcaFactory.php:35ReplyDone -
Stefan Bürk voted on patch set 9 CR +1 V +1 11/23/23, 08:49
-
Torben Hansen voted on patch set 9 CR +1 V +1 11/23/23, 09:06
-
Benjamin Franzke voted on patch set 9 CR +1 11/23/23, 09:46
-
Benjamin Franzke voted on patch set 9 CR +2 V +2 11/23/23, 09:47
-
Benjamin Franzke merged patch set 10 11/23/23, 09:47
-
Andreas Wolf commented on patch set 9 CR +1 11/23/23, 10:20
Code looks good, my remarks only touch comments/formatting/naming.AfterTcaCompilationEvent.php:21UnresolvedSuggestion: "Event after $tca – which later becomes $GLOBALS['TCA'] – has been built." (or use commas or put it into ())BeforeTcaOverridesEvent.php:21UnresolvedSuggestion: "before $tca – which later becomes $GLOBALS['TCA'] – " (or use commas or put it into ())TcaFactory.php:42UnresolvedThat comment seems odd?TcaFactory.php:46UnresolvedIf this is the actual cached data, $cachedData is probably more understandable? "cacheData" could also be a flag, esp. since we use it in the if in the next line.TcaFactory.php:121UnresolvedCan we split this monster into multiple lines?TcaFactory.php:128UnresolvedShould we log a warning in the else-branch?TcaFactory.php:150UnresolvedSame here, this would benefit from some line breaks IMO.Feature-102067-BeforeTcaOverridesEvent.rst:52UnresolvedShould this note probably be included in the event?ExtensionManagementUtilityTest.php:1282UnresolvedFewer mocks \o/
TcaFactory.php:35