Review main Merged

81600[TASK] Extract TCA loading to a factory

Christian Kuhn CR +2 V +2 Hard +249 −436 updated 11/23/23, 10:20

Commit message

Having TCA creation related code within static
ExtensionManagementUtility is unflexible and no
good architecture.

The patch extracts TCA creation to a factory used
by bootstrap for the different scopes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1726

Show 1 earlier messages
  1. Christian Kuhn uploaded patch set 1 10/27/23, 15:58

  1. Christian Kuhn uploaded patch set 2 10/27/23, 16:02

  2. core-ci voted on patch set 1 V +1 10/27/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48299

  3. core-ci voted on patch set 2 V +1 10/27/23, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48300

  4. Christian Kuhn uploaded patch set 3 V +1 10/27/23, 16:14

  5. core-ci voted on patch set 3 V +1 10/27/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48302

  6. Christian Kuhn uploaded patch set 4 V +1 10/27/23, 18:34

  7. core-ci voted on patch set 4 V +1 10/27/23, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48311

  8. Benjamin Franzke uploaded patch set 5 V +1 11/01/23, 09:34

  9. core-ci voted on patch set 5 V +1 11/01/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48433

  10. Benjamin Franzke uploaded patch set 6 V +1 11/01/23, 09:49

  11. core-ci voted on patch set 6 V +1 11/01/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48435

  12. Benjamin Franzke rebased onto patch set 7 V +1 11/22/23, 20:53

  13. core-ci voted on patch set 7 V +1 11/22/23, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49549

  14. Christian Kuhn uploaded patch set 8 V +1 11/22/23, 21:12

  15. core-ci voted on patch set 8 V -1 11/22/23, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49555

  16. Christian Kuhn uploaded patch set 9 V -1 11/22/23, 21:28

  17. core-ci voted on patch set 9 V +1 11/22/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49559

  18. Torben Hansen commented on patch set 9 11/23/23, 07:45

    TcaFactory.php:35

    I think all arguments can be `readonly`
  19. Christian Kuhn commented on patch set 9 11/23/23, 08:40

    TcaFactory.php:35 Reply

    Done
  20. Stefan Bürk voted on patch set 9 CR +1 V +1 11/23/23, 08:49

  21. Torben Hansen voted on patch set 9 CR +1 V +1 11/23/23, 09:06

  22. Benjamin Franzke voted on patch set 9 CR +1 11/23/23, 09:46

  23. Benjamin Franzke voted on patch set 9 CR +2 V +2 11/23/23, 09:47

  24. Benjamin Franzke merged patch set 10 11/23/23, 09:47

  25. Andreas Wolf commented on patch set 9 CR +1 11/23/23, 10:20

    Code looks good, my remarks only touch comments/formatting/naming.

    AfterTcaCompilationEvent.php:21 Unresolved

    Suggestion: "Event after $tca – which later becomes $GLOBALS['TCA'] – has been built." (or use commas or put it into ())

    BeforeTcaOverridesEvent.php:21 Unresolved

    Suggestion: "before $tca – which later becomes $GLOBALS['TCA'] – " (or use commas or put it into ())

    TcaFactory.php:42 Unresolved

    That comment seems odd?

    TcaFactory.php:46 Unresolved

    If this is the actual cached data, $cachedData is probably more understandable? "cacheData" could also be a flag, esp. since we use it in the if in the next line.

    TcaFactory.php:121 Unresolved

    Can we split this monster into multiple lines?

    TcaFactory.php:128 Unresolved

    Should we log a warning in the else-branch?

    TcaFactory.php:150 Unresolved

    Same here, this would benefit from some line breaks IMO.

    Feature-102067-BeforeTcaOverridesEvent.rst:52 Unresolved

    Should this note probably be included in the event?

    ExtensionManagementUtilityTest.php:1282 Unresolved

    Fewer mocks \o/