81605[FEATURE] Provide full userdata in password recovery email
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Guido Schmechel +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-100268-ProvideFullUserdataInPasswordRecoveryEmail.rst4new+25 −0
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserRepository.php3+9 −4
- typo3/sysext/felogin/Classes/Service/RecoveryService.php2+3 −2
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php2+1 −0
Review log 1823
-
Torben Hansen uploaded patch set 1 10/28/23, 16:42
-
core-ci voted on patch set 1 V +1 10/28/23, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48330
-
Oliver Klee voted on patch set 1 CR +1 10/29/23, 13:32
-
Garvin Hicking commented on patch set 1 10/29/23, 16:53
RecoveryService.php:102Maybe strip "password" at this place, to harden not exposing hashed passwords in possible attack scenarios? -
Torben Hansen uploaded patch set 2
CR +1V +110/29/23, 17:16 -
Torben Hansen commented on patch set 2 10/29/23, 17:19
Feature-100268-ProvideFullUserdataInPasswordRecoveryEmail.rst:15ReplyDoneRecoveryService.php:102ReplyUnsure if it is possible to construct a valid attack scenario here, but I removed the hash from the `userData` array now, since it is useless in the fluid template anyway. -
core-ci voted on patch set 2 V +1 10/29/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48338
-
Garvin Hicking commented on patch set 2 V +1 CR +1 10/29/23, 17:44
Thanks for the patch, this definitely eases up sending these mails, if customization is needed.Feature-100268-ProvideFullUserdataInPasswordRecoveryEmail.rst:16Oh well, I'm sorry, my addition only made partial sense. Here's another approach: A new array variable :php:`{userData}` has been added to the password recovery FluidEmail object. It contains the values of all fields belonging to the affected frontend user.RecoveryServiceTest.php:82Minor gripe - the other key pairs are indented to align with each other, maybe the spaces could be added here too 🫣 -
Benni Mack commented on patch set 2 10/31/23, 11:07
FrontendUserRepository.php:128let's just unset password for the sake of being at least a little bit concerned. -
Torben Hansen commented on patch set 2 10/31/23, 11:14
FrontendUserRepository.php:128ReplyThis password is unset in RecoveryService, but I will update the patch the unset the password in FrontendUserRepository (if user is found) -
Torben Hansen uploaded patch set 3
CR +1V +110/31/23, 11:36 -
Torben Hansen uploaded patch set 4 10/31/23, 11:38
-
Torben Hansen commented on patch set 4 10/31/23, 11:39
Feature-100268-ProvideFullUserdataInPasswordRecoveryEmail.rst:16ReplyDoneFrontendUserRepository.php:128ReplyDoneRecoveryServiceTest.php:82ReplyDone -
Garvin Hicking voted on patch set 4 V +1 CR +1 10/31/23, 11:43
-
core-ci voted on patch set 3 V +1 10/31/23, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48398
-
core-ci voted on patch set 4 V +1 10/31/23, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48399
-
Oliver Klee voted on patch set 4 CR +1 10/31/23, 11:53
-
Torben Hansen rebased onto patch set 5
CR +1V +112/02/23, 14:08 -
core-ci voted on patch set 5 V +1 12/02/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50250
-
Garvin Hicking voted on patch set 5 CR +1 V +1 12/02/23, 14:57
-
Guido Schmechel voted on patch set 5 CR +1 12/03/23, 12:26
-
Benni Mack voted on patch set 5 CR +2 V +2 12/03/23, 19:37
-
Benni Mack merged patch set 6 12/03/23, 19:37
Feature-100268-ProvideFullUserdataInPasswordRecoveryEmail.rst:15