Review main Merged

81607[TASK] Use strict types in QueryResultPaginator

Torben Hansen CR +2 V +2 Easy +2 −11 updated 11/13/23, 19:39

Commit message

Properties in extbase `QueryResultPaginator` do not use strict
types.

This change introduces strict types for the properties
in extbase `QueryResultPaginator`. Since the class is
defined as final, the change is not considered breaking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Torben Hansen uploaded patch set 1 10/29/23, 13:54

  2. Torben Hansen uploaded patch set 2 10/29/23, 13:55

  3. Oliver Klee voted on patch set 2 V +1 CR +1 10/29/23, 13:59

  4. core-ci voted on patch set 2 V +1 10/29/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48337

  5. core-ci voted on patch set 1 V +1 10/29/23, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48336

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/29/23, 20:54

  7. Torben Hansen wrote 11/11/23, 13:47

    Topic set to extbase
  8. Benni Mack voted on patch set 2 V +2 CR +2 11/13/23, 19:39

  9. Benni Mack merged patch set 3 11/13/23, 19:39