Review 12.4 Merged

81633[BUGFIX] Update `phpstan/phpstan` to 1.10.40

Andreas Kienast CR +2 V +2 Easy +13 −18 updated 10/31/23, 09:02

Commit message

This commit updates `phpstan/phpstan` to the latest version and fixes
one quirk in our code in order to make our nightly test runs happy
again.

Executed command:

    composer require --dev phpstan/phpstan:^1.10.40 -W

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 58

  1. Andreas Kienast uploaded patch set 1 10/31/23, 07:27

  2. core-ci voted on patch set 1 V +1 10/31/23, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48382

  3. Andreas Kienast uploaded patch set 2 V +1 10/31/23, 07:55

  4. core-ci voted on patch set 2 V +1 10/31/23, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48385

  5. Andreas Kienast uploaded patch set 3 V +1 10/31/23, 08:32

  6. core-ci voted on patch set 3 V +1 10/31/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48387

  7. Andreas Kienast voted on patch set 3 V +2 CR +2 10/31/23, 09:02

  8. Andreas Kienast merged patch set 4 10/31/23, 09:02