Review main Abandoned Breaking

81635[!!!][WIP][TASK] Use DTO for dealing with page cache

Benni Mack CR 0 V 0 Normal +163 −38 updated 09/14/24, 20:11

Commit message

When rendering a page in the frontend
for the first time, all information which
is needed for rendering a page the second time
(including "nonCachebleData") is now handled in
one object.

This serves as a basis to further
refactorings of the logic of $TSFE->config,
which can then be split up in
* instructions $TSFE->config[config]
* TypoScript rootline $TSFE->config[rootLine]
* nonCacheble (INTincScript and INTincScript_ext)

The PageCacheData object can then be put into

This change is breaking as the existing hook
"pageLoadedFromCache" now receives an object instead
of an array.

The next step is now to create another patch
that actually does not use the $tsfe->config['config']
array anymore.

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 812

  1. Benni Mack uploaded patch set 1 10/31/23, 14:44

  2. Benni Mack updated the commit message in patch set 2 10/31/23, 14:44

  3. Benni Mack uploaded patch set 3 10/31/23, 14:53

  4. core-ci voted on patch set 1 V -1 10/31/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48408

  5. core-ci voted on patch set 2 V -1 10/31/23, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48409

  6. core-ci voted on patch set 3 V -1 10/31/23, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48410

  7. Benni Mack uploaded patch set 4 V -1 10/31/23, 22:05

  8. core-ci voted on patch set 4 V +1 10/31/23, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48418

  9. Simon Schaufelberger commented on patch set 4 01/04/24, 01:20

    will this patch make it for v13?
  10. Simon Schaufelberger commented on patch set 4 01/25/24, 14:16

    Reply Unresolved

    @benni@typo3.org will this patch make it for v13?
  11. Oliver Klee wrote 08/25/24, 10:11

    Removed cc Oliver Klee.
  12. Benni Mack abandoned the change 09/14/24, 20:11

    looks like this patch won't make it in v13, as another approach was merged.