Review main Merged

81636[TASK] Simplify check for ResourceCompressor HTML5 doctype

Benni Mack CR +2 V +2 Easy +9 −15 updated 11/02/23, 13:55

Commit message

Even though ResourceCompressor is not used
in BE context anymore, the check for HTML5 doctype
is now based on PageRenderer instead of TSFE
as it is available as a singleton and not
as a global dependency.

In addition, this reduces a cross-dependency
between EXT:frontend and EXT:core.

Introducing DI etc. for ResourceCompressor
can follow at a later stage.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1418

  1. Benni Mack uploaded patch set 1 10/31/23, 15:04

  2. core-ci voted on patch set 1 V -1 10/31/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48411

  3. Benni Mack uploaded patch set 2 V -1 11/02/23, 08:02

  4. core-ci voted on patch set 2 V +1 11/02/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48473

  5. Andreas Kienast voted on patch set 2 CR +1 11/02/23, 08:45

  6. Oliver Klee commented on patch set 2 11/02/23, 08:49

    ResourceCompressor.php:677

    Can/should we use a strict comparison?
  7. Benni Mack commented on patch set 3 CR +1 V +1 11/02/23, 10:29

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 3 11/02/23, 10:30

    ResourceCompressor.php:677 Reply

    Done
  9. core-ci voted on patch set 3 V +1 11/02/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48480

  10. Andreas Kienast voted on patch set 3 CR +1 11/02/23, 10:48

  11. Andreas Kienast voted on patch set 3 V +1 11/02/23, 10:57

  12. Benni Mack updated the commit message in patch set 4 CR +1 V +1 11/02/23, 11:32

  13. core-ci voted on patch set 4 V +1 11/02/23, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48481

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 11/02/23, 11:47

  15. Oliver Klee voted on patch set 4 CR +1 11/02/23, 12:13

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 11/02/23, 13:54

  17. Benni Mack voted on patch set 4 V +2 CR +2 11/02/23, 13:55

  18. Benni Mack merged patch set 5 11/02/23, 13:55