Review main Merged

81637[BUGFIX] Prefix fields with table name in SuggestWizardDefaultReceiver

Achim Fritz CR +2 V +2 Easy +2 −2 updated 11/02/23, 15:48

Commit message

To prevents sql errors when inherit from
SuggestWizardDefaultReceiver and adding a
JOIN statement, the fields are now prefixed
with the table name.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Achim Fritz uploaded patch set 1 10/31/23, 15:20

  2. core-ci voted on patch set 1 V +1 10/31/23, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48412

  3. Oli Bartsch updated the commit message in patch set 2 V +1 10/31/23, 18:22

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 10/31/23, 18:22

  5. core-ci voted on patch set 2 V +1 10/31/23, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48416

  6. Oliver Klee voted on patch set 2 CR +1 10/31/23, 19:53

  7. Garvin Hicking voted on patch set 2 V +1 CR +1 11/02/23, 12:59

  8. Guido Schmechel voted on patch set 2 CR +1 11/02/23, 13:45

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 11/02/23, 15:48

  10. Oli Bartsch merged patch set 3 11/02/23, 15:48