Review main Merged

81638[BUGFIX] Allow creating bookmark after it was removed

Marcin Sągol CR +2 V +2 Normal +60 −8 updated 11/21/23, 11:39

Commit message

This commit addresses 2 bugs in BE bookmarks management:

- After adding and removing a page from bookmarks, it couldn't be
  re-added without reloading the page.

- If a page was bookmarked, the bookmark button wasn't marked as
  inactive/disabled during BE content rendering.

Given the current implementation challenges, like the inability to
reload the shortcuts dropdown view and difficulty in modifying
backend button classes, most of the handling was delegated to the FE.

- BE always returns the shortcut button with necessary data attributes
  for frontend dispatch actions. BE only sets (or omits) the
  `data-dispatch-disabled` and `disabled` attributes.

- For every bookmarked entry, the BE also provides its `route` and
  `args`.

- Upon FE bookmark removal, the BE response includes the `route` and
  `args`. The FE uses these to match the shortcut button's data
  attributes and, if they match, enables the button.

This change is effective for both the shortcuts dropdown and the
standalone bookmark button.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Annett Jähnichen +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1319

  1. Marcin Sągol uploaded patch set 1 10/31/23, 15:56

  2. Marcin Sągol updated the commit message in patch set 2 10/31/23, 16:00

  3. core-ci voted on patch set 1 V -1 10/31/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48413

  4. core-ci voted on patch set 2 V -1 10/31/23, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48414

  5. Marcin Sągol uploaded patch set 3 V -1 10/31/23, 16:08

  6. core-ci voted on patch set 3 V -1 10/31/23, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48415

  7. Chris Müller commented on patch set 3 CR -1 11/01/23, 08:51

    The "Resolves" and "Releases" line should be at the end of the commit message, directly before "Change-Id".
  8. Marcin Sągol uploaded patch set 4 CR -1 V -1 11/01/23, 11:36

  9. Marcin Sągol updated the commit message in patch set 5 11/01/23, 11:37

  10. core-ci voted on patch set 4 V +1 11/01/23, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48437

  11. core-ci voted on patch set 5 V +1 11/01/23, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48438

  12. Marcin Sągol commented on patch set 5 11/01/23, 14:09

    Reply

    Done
  13. Andreas Kienast commented on patch set 5 V -1 11/02/23, 13:26

    Removing any bookmark re-enables the bookmark button again. Will check.
  14. Andreas Kienast uploaded patch set 6 V +1 11/02/23, 13:28

  15. Andreas Kienast voted on patch set 6 V +1 CR +1 11/02/23, 13:28

  16. core-ci voted on patch set 6 V +1 11/02/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48493

  17. Annett Jähnichen voted on patch set 6 V +1 11/21/23, 10:49

  18. Christian Kuhn voted on patch set 6 V +2 CR +2 11/21/23, 11:23

  19. Christian Kuhn merged patch set 7 11/21/23, 11:39