81639[BUGFIX] Add missing additionalAttributes to Fieldset
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Henrik Ziegenhain +1
- Sebastian Klein +1
-
Verified V +2 Done
- Christian Kuhn +2
- Henrik Ziegenhain +1
- Sebastian Klein +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1621
-
Henrik Ziegenhain uploaded patch set 1 11/01/23, 05:49
-
core-ci voted on patch set 1 V -1 11/01/23, 05:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48422
-
Henrik Ziegenhain uploaded patch set 2
V -111/01/23, 07:11 -
core-ci voted on patch set 2 V +1 11/01/23, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48423
-
Sebastian Klein commented on patch set 2 CR -1 V +1 08/01/24, 19:48
Fieldset.html:4All f:for VH in core first set the "each" argument, then "as" (and "key"). Reads better. Can we align this? -
Patrick Schriner uploaded patch set 3
CR -1V +108/01/24, 20:19 -
Patrick Schriner commented on patch set 3 08/01/24, 20:20
Fieldset.html:4ReplyDoneFieldset.html:4ReplyDone -
core-ci voted on patch set 3 V -1 08/01/24, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62641
-
Sebastian Klein voted on patch set 3 CR +1 V +1 08/01/24, 20:35
-
Patrick Schriner commented on patch set 3 08/01/24, 21:38
I cannot reproduce the acceptance test failure. Help? -
core-ci voted on patch set 3 V +1 08/02/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62641
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 08/02/24, 08:06
-
Henrik Ziegenhain voted on patch set 3 CR +1 08/02/24, 10:42
-
Henrik Ziegenhain voted on patch set 3 V +1 08/02/24, 10:42
-
Benni Mack updated the commit message in patch set 4
CR +1V +108/02/24, 20:06 -
core-ci voted on patch set 4 V +1 08/02/24, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62769
-
Henrik Ziegenhain voted on patch set 4 V +1 08/03/24, 06:58
-
Henrik Ziegenhain voted on patch set 4 CR +1 08/03/24, 06:58
-
Sebastian Klein voted on patch set 4 CR +1 V +1 08/05/24, 17:21
-
Christian Kuhn voted on patch set 4 CR +2 V +2 08/06/24, 07:27
-
Christian Kuhn merged patch set 5 08/06/24, 07:48
Fieldset.html:4