Review main Merged

81643[TASK] Remove jQuery from module menu

Andreas Kienast CR +2 V +2 Easy +17 −21 updated 11/03/23, 08:08

Commit message

This patch removes jQuery from the `@typo3/backend/module-menu` module.
Collapsing/expanding of the module groups is now done by Bootstrap's
`Collapse` module.

The usage of `$.Deferred()` has been removed without replacement, this
looks like a weird hack required back then.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Andreas Kienast uploaded patch set 1 11/02/23, 09:20

  2. core-ci voted on patch set 1 V +1 11/02/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48476

  3. Andreas Kienast uploaded patch set 2 V +1 11/02/23, 10:11

  4. core-ci voted on patch set 2 V +1 11/02/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48477

  5. Andreas Kienast updated the commit message in patch set 3 V +1 11/02/23, 10:27

  6. core-ci voted on patch set 3 V +1 11/02/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48479

  7. Benni Mack voted on patch set 3 CR +1 11/02/23, 12:20

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 11/02/23, 16:30

  9. Benni Mack voted on patch set 3 V +1 11/02/23, 16:47

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 11/03/23, 08:08

  11. Oli Bartsch merged patch set 4 11/03/23, 08:08