Review main Merged

81647[TASK] Remove jQuery from `@typo3/backend/viewport/toolbar` module

Andreas Kienast CR +2 V +2 Easy +8 −5 updated 11/06/23, 05:36

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Andreas Kienast uploaded patch set 1 11/02/23, 14:19

  2. Andreas Kienast uploaded patch set 2 11/02/23, 14:20

  3. core-ci voted on patch set 2 V +1 11/02/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48499

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 11/02/23, 16:24

  5. Benjamin Franzke commented on patch set 2 CR -1 11/04/23, 10:06

    toolbar.ts:19

    This had an implicit "DocumentReady" waiter before, as the callback was passed to `JQuery`. How are you sure this is not longer required. As far as I see this could be racy, as the callers (like ClearCacheMenu) invoke this method as soon as the module is loaded, and it is not guaranteed that the entire DOM structure is loaded at that point. so i'd say better we use DocumentReadyService
  6. Benjamin Franzke uploaded patch set 3 CR +1 V +1 11/04/23, 11:02

  7. Benjamin Franzke commented on patch set 3 11/04/23, 11:02

    toolbar.ts:19 Reply

    Done
  8. Benjamin Franzke voted on patch set 3 V +1 CR +1 11/04/23, 11:03

  9. core-ci voted on patch set 3 V +1 11/04/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48564

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/05/23, 09:36

  11. Benjamin Franzke voted on patch set 3 V +2 CR +2 11/06/23, 05:36

  12. Benjamin Franzke merged patch set 4 11/06/23, 05:36