Review main Merged

81674[TASK] Re-add extension-key to styleguide's composer.json

Benjamin Franzke CR +2 V +2 Normal +37 −34 updated 11/03/23, 12:54

Commit message

The extension key setting was accidentally dropped in one
of the monorepo merge preparation changes:
https://github.com/TYPO3-CMS/styleguide/pull/475

Also reformat to use tabs as in other composer.json files.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Benjamin Franzke uploaded patch set 1 11/03/23, 11:37

  2. core-ci voted on patch set 1 V +1 11/03/23, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48536

  3. Jasmina Ließmann voted on patch set 1 CR +1 11/03/23, 11:44

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 11/03/23, 12:02

  5. Garvin Hicking commented on patch set 1 V +1 CR +1 11/03/23, 12:15

    😊
  6. Benni Mack voted on patch set 1 V +1 CR +1 11/03/23, 12:16

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/03/23, 12:22

  8. Benjamin Franzke merged patch set 2 11/03/23, 12:22

  9. Oliver Hader voted on patch set 2 CR +1 11/03/23, 12:54