Review main Merged

81675[BUGFIX] Enforce light mode in EXT:styleguide examples

Andreas Kienast CR +2 V +2 Easy +3 −1 updated 11/03/23, 12:53

Commit message

EXT:styleguide is not fully compatible to dark mode environments. For
the time being, light mode is enforce in examples until further
groundwork is done.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 11/03/23, 12:00

  2. Andreas Kienast uploaded patch set 2 11/03/23, 12:01

  3. Benjamin Franzke voted on patch set 2 V +1 CR +1 11/03/23, 12:08

  4. core-ci voted on patch set 1 V +1 11/03/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48537

  5. Garvin Hicking commented on patch set 2 V +1 CR +1 11/03/23, 12:10

    🎶I can see clearly now the dark is gone🎶 (Thanks!!)
  6. core-ci voted on patch set 2 V +1 11/03/23, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48538

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 11/03/23, 12:30

  8. Andreas Kienast merged patch set 3 11/03/23, 12:31

  9. Oliver Hader voted on patch set 3 CR +1 11/03/23, 12:53