Review main Abandoned

81684[TASK] Apply CKEditor5 migration during element render

Benjamin Franzke CR 0 V 0 Normal +44 −111 updated 10/03/26, 06:36

Commit message

The migration has previously been performed in EXT:core
as a post-step of the configuration-loader.
This migration is now moved into EXT:rte_ckeditor in
order to allow migration rules for `extraPlugins`
that are derived from `externalPlugins` during element
render – this also allowed to apply migration to
event-modified settings.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 68

  1. Benjamin Franzke uploaded patch set 1 11/04/23, 15:20

  2. core-ci voted on patch set 1 V -1 11/04/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48584

  3. Benjamin Franzke marked it work in progress 11/04/23, 18:01

  4. Benjamin Franzke uploaded patch set 2 V -1 12/12/23, 07:42

  5. core-ci voted on patch set 2 V +1 12/12/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50577

  6. Oliver Hader updated the commit message in patch set 3 V +1 10/18/24, 14:08

  7. Benni Mack commented on patch set 3 09/26/26, 13:17

    Unresolved

    do we still care about this change? The issue is about the migration and obviously, nobody pushed this further in the past 2 years. The patch is stalled in our WIP dumpster, and nobody complained further. I suggest to abandon the patch and close the issue.
  8. Benjamin Franzke abandoned the change 10/03/26, 06:36

    Closing, we never managed to merge the patch because of fear we break more than we fix. It is probably not needed any longer anyway.