Review main Merged

81690[BUGFIX] Update `phpstan/phpstan` to 1.10.41

Andreas Kienast CR +2 V +2 Easy +14 −8 updated 11/06/23, 09:03

Commit message

This commit updates `phpstan/phpstan` to the latest version and fixes
one issue within `RedisSessionBackend` where the Redis API claims to
return a `\Redis` object when calling `->del()`. This indicates a usage
of multi mode, where the delete state cannot get determined.
Also, multi mode is not supported by our session backend, therefore we
handle this case as "not successful" now.

Executed command:

    composer require --dev phpstan/phpstan:^1.10.41 -W

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Andreas Kienast uploaded patch set 1 11/06/23, 08:10

  2. Andreas Kienast updated the commit message in patch set 2 11/06/23, 08:11

  3. Benjamin Franzke voted on patch set 2 V +1 CR +1 11/06/23, 08:13

  4. core-ci voted on patch set 1 V +1 11/06/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48612

  5. core-ci voted on patch set 2 V +1 11/06/23, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48614

  6. Oliver Klee voted on patch set 2 V +1 CR +1 11/06/23, 08:34

  7. Benni Mack voted on patch set 2 V +1 CR +1 11/06/23, 08:44

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 11/06/23, 08:51

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 11/06/23, 08:52

  10. Andreas Kienast merged patch set 3 11/06/23, 09:03