Review 12.4 Merged

81691[BUGFIX] Update `phpstan/phpstan` to 1.10.41

Andreas Kienast CR +2 V +2 Easy +14 −8 updated 11/06/23, 09:03

Commit message

This commit updates `phpstan/phpstan` to the latest version and fixes
one issue within `RedisSessionBackend` where the Redis API claims to
return a `\Redis` object when calling `->del()`. This indicates a usage
of multi mode, where the delete state cannot get determined.
Also, multi mode is not supported by our session backend, therefore we
handle this case as "not successful" now.

Executed command:

    composer require --dev phpstan/phpstan:^1.10.41 -W

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 11/06/23, 08:53

  2. core-ci voted on patch set 1 V +1 11/06/23, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48619

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 11/06/23, 09:03

  4. Andreas Kienast merged patch set 2 11/06/23, 09:03