81695[BUGFIX] Abort CLI installation when no databases are available.
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2026
Show 1 earlier messages
-
Garvin Hicking uploaded patch set 1 11/06/23, 14:06
-
core-ci voted on patch set 1 V +1 11/06/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48660
-
Garvin Hicking uploaded patch set 2
V +111/06/23, 14:19Move failure check to question handler -
Garvin Hicking commented on patch set 2 11/06/23, 14:22
Note: This doesn't make the command be on feature-parity with the web-based installer. CLI bails out when the DB doesn't exist; web is able to create non-existant DB at this stage. (I'd argue that would need to be more of a TASK/FEATURE step, not a bugfix) -
core-ci voted on patch set 2 V +1 11/06/23, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48661
-
Chris Müller commented on patch set 2 11/06/23, 21:26
SetupCommand.php:310I would prefer "$dbChoices === []". This improves the performance a little bit. -
Garvin Hicking uploaded patch set 3
V +111/07/23, 10:50 -
Garvin Hicking commented on patch set 3 11/07/23, 10:51
SetupCommand.php:310ReplyDone -
core-ci voted on patch set 3 V +1 11/07/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48685
-
Christian Kuhn voted on patch set 3 V +1 CR +1 11/20/23, 14:57
-
Christian Kuhn uploaded patch set 4
CR +1V +111/20/23, 15:01 -
Christian Kuhn voted on patch set 4 V +1 CR +1 11/20/23, 15:01
-
Andreas Nedbal voted on patch set 4 V +1 CR +1 11/20/23, 15:02
-
Christian Kuhn voted on patch set 4 V +2 CR +2 11/20/23, 15:02
-
Oli Bartsch commented on patch set 3 11/20/23, 15:03
SetupCommand.php:279Can we already throw the exception here, in case $databaseList is empty? -
Oliver Klee voted on patch set 4 CR +1 11/20/23, 15:04
-
Oli Bartsch voted on patch set 4 V -1 11/20/23, 15:06
-
Christian Kuhn voted on patch set 4 V 0 CR 0 11/20/23, 15:06
-
Oli Bartsch uploaded patch set 5
CR +1V +111/20/23, 15:08 -
core-ci voted on patch set 4 V +1 11/20/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49141
-
Oli Bartsch uploaded patch set 6 11/20/23, 15:11
-
Oli Bartsch commented on patch set 6 V +1 CR +1 11/20/23, 15:11
SetupCommand.php:279ReplyDone -
core-ci voted on patch set 5 V -1 11/20/23, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49143
-
core-ci voted on patch set 6 V +1 11/20/23, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49145
-
Christian Kuhn voted on patch set 6 V +2 CR +2 11/20/23, 15:29
-
Christian Kuhn merged patch set 7 11/20/23, 15:29