Review main Merged

81695[BUGFIX] Abort CLI installation when no databases are available.

Garvin Hicking CR +2 V +2 Easy +5 −0 updated 11/20/23, 15:29

Commit message

Note: This patch doesn't make the command be on feature-parity
with the web-based installer. CLI bails out when the DB doesn't exist;
web is able to create non-existant DB at this stage. This would need
implementation as a follow-up feature.

This patch only addresses not raising an exception on CLI installation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2026

Show 1 earlier messages
  1. Garvin Hicking uploaded patch set 1 11/06/23, 14:06

  1. core-ci voted on patch set 1 V +1 11/06/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48660

  2. Garvin Hicking uploaded patch set 2 V +1 11/06/23, 14:19

    Move failure check to question handler
  3. Garvin Hicking commented on patch set 2 11/06/23, 14:22

    Note: This doesn't make the command be on feature-parity with the web-based installer. CLI bails out when the DB doesn't exist; web is able to create non-existant DB at this stage. (I'd argue that would need to be more of a TASK/FEATURE step, not a bugfix)
  4. core-ci voted on patch set 2 V +1 11/06/23, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48661

  5. Chris Müller commented on patch set 2 11/06/23, 21:26

    SetupCommand.php:310

    I would prefer "$dbChoices === []". This improves the performance a little bit.
  6. Garvin Hicking uploaded patch set 3 V +1 11/07/23, 10:50

  7. Garvin Hicking commented on patch set 3 11/07/23, 10:51

    SetupCommand.php:310 Reply

    Done
  8. core-ci voted on patch set 3 V +1 11/07/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48685

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 11/20/23, 14:57

  10. Christian Kuhn uploaded patch set 4 CR +1 V +1 11/20/23, 15:01

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 11/20/23, 15:01

  12. Andreas Nedbal voted on patch set 4 V +1 CR +1 11/20/23, 15:02

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 11/20/23, 15:02

  14. Oli Bartsch commented on patch set 3 11/20/23, 15:03

    SetupCommand.php:279

    Can we already throw the exception here, in case $databaseList is empty?
  15. Oliver Klee voted on patch set 4 CR +1 11/20/23, 15:04

  16. Oli Bartsch voted on patch set 4 V -1 11/20/23, 15:06

  17. Christian Kuhn voted on patch set 4 V 0 CR 0 11/20/23, 15:06

  18. Oli Bartsch uploaded patch set 5 CR +1 V +1 11/20/23, 15:08

  19. core-ci voted on patch set 4 V +1 11/20/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49141

  20. Oli Bartsch uploaded patch set 6 11/20/23, 15:11

  21. Oli Bartsch commented on patch set 6 V +1 CR +1 11/20/23, 15:11

    SetupCommand.php:279 Reply

    Done
  22. core-ci voted on patch set 5 V -1 11/20/23, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49143

  23. core-ci voted on patch set 6 V +1 11/20/23, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49145

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 11/20/23, 15:29

  25. Christian Kuhn merged patch set 7 11/20/23, 15:29